Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 168463 - games-action/descent2-data-1.1.ebuild (Update/Enhancement)
Summary: games-action/descent2-data-1.1.ebuild (Update/Enhancement)
Status: VERIFIED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Games (show other bugs)
Hardware: All Linux
: High enhancement
Assignee: Gentoo Games
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-02-26 13:46 UTC by Hendrik Iben
Modified: 2007-03-07 21:40 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
descent2-data ebuild with optional movie installation. (descent2-data-1.1.ebuild,2.69 KB, text/plain)
2007-02-26 13:48 UTC, Hendrik Iben
Details
descent2-data-1.0.ebuild (descent2-data-1.0.ebuild,2.28 KB, text/plain)
2007-02-26 15:05 UTC, Paul Bredbury
Details
descent2-data-1.0.ebuild (descent2-data-1.0.ebuild,2.29 KB, text/plain)
2007-02-26 15:10 UTC, Paul Bredbury
Details
descent2-data-1.0.ebuild (descent2-data-1.0.ebuild,2.50 KB, text/plain)
2007-02-26 16:25 UTC, Paul Bredbury
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Hendrik Iben 2007-02-26 13:46:54 UTC
The current descent2-data ebuild does not install the movie-files.

I have modified the ebuild so you can enable the installation of movies by two USE-Flags : lowres and highres.
If used, the corresponding movie-files will be copied (if they exist) either from the original CD or from the files-directory.
Comment 1 Hendrik Iben 2007-02-26 13:48:05 UTC
Created attachment 111286 [details]
descent2-data ebuild with optional movie installation.
Comment 2 Paul Bredbury 2007-02-26 14:22:43 UTC
The version remains 1.0, not 1.1
Comment 3 Paul Bredbury 2007-02-26 15:05:39 UTC
Created attachment 111310 [details]
descent2-data-1.0.ebuild

Tidied ebuild.
Comment 4 Paul Bredbury 2007-02-26 15:10:32 UTC
Created attachment 111312 [details]
descent2-data-1.0.ebuild

Oops, added "-f" to ensure that potentially read-only files copied from the CD can be overwritten.
Comment 5 Hendrik Iben 2007-02-26 16:03:13 UTC
Why should only one movieset be copied ?
Is it so unlikely that someone might want to use low resolution with one client while using high resolution with an other ?
Comment 6 Paul Bredbury 2007-02-26 16:25:51 UTC
Created attachment 111318 [details]
descent2-data-1.0.ebuild

OK, this ebuild allows both.
Comment 7 Chris Gianelloni (RETIRED) gentoo-dev 2007-03-07 15:48:58 UTC
I'm sure I'll catch hell for this, but I don't see a point in only installing one or the other movies, so I've changed the USE to be "videos" and am installing both for everybody, instead.

Also, I *really* hate that FILESDIR crap, but I've left it in the ebuild even though one can just point their CD_ROOT to the proper location and be done with it without having to deal with keeping a copy of the ebuild in an overlay.  Don't be surprised if I end up removing it at some point, since I consider it to be redundant.  I mean, *maybe* if it were using DISTDIR instead of FILESDIR, it would be OK.
Comment 8 Hendrik Iben 2007-03-07 16:15:48 UTC
(In reply to comment #7)
> I mean, *maybe* if it were using DISTDIR instead of FILESDIR,
> it would be OK.
> 

I totally agree to that DISTDIR would make a lot more sense.
Installing both video-types is fine for me. Maybe storage-space is cheap enough so that nobody cares about an option anyway... :)
Comment 9 Chris Gianelloni (RETIRED) gentoo-dev 2007-03-07 21:40:34 UTC
Changed.