Bug 168373 – xfce44.eclass + panel/thunar plugins get DEPEND wrong

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Jakub Moc (RETIRED) 2007-02-25 20:30:45 UTC]

We don't DEPEND on xfce-panel or thunar, only RDEPEND, which is wrong. See eclass patch below:

<snip>
--- xfce44.eclass	2007-02-25 20:43:00.000000000 +0100
+++ xfce44.eclass	2007-02-25 20:44:01.000000000 +0100
@@ -61,12 +61,14 @@
 xfce44_panel_plugin() {
 	xfce44_plugin
 	RDEPEND="${RDEPEND} >=xfce-base/xfce4-panel-${XFCE_MASTER_VERSION}"
+	DEPEND="${DEPEND} >=xfce-base/xfce4-panel-${XFCE_MASTER_VERSION}"
 }
 
 xfce44_thunar_plugin() {
 	xfce44_plugin
 	HOMEPAGE="http://thunar.xfce.org/pwiki/projects/${MY_PN}"
 	RDEPEND="${RDEPEND} >=xfce-base/thunar-${THUNAR_MASTER_VERSION}"
+	DEPEND="${DEPEND} >=xfce-base/thunar-${THUNAR_MASTER_VERSION}"
 }
 
 ## sets SRC_URI and HOMEPAGE to berlios
</snip>

Additionally, the following ebuilds need to have 

xfce44
xfce44_goodies_panel_plugin (or xfce44_goodies_thunar_plugin)

functions call moved, so that it appears *after* setting DEPEND/RDEPEND in the ebuilds.

xfce-extra/verve-0.3.5
xfce-extra/xfce4-battery-0.5.0-r1
xfce-extra/xfce4-cpugraph-0.3.0
xfce-extra/xfce4-dict-0.2.1
xfce-extra/xfce4-eyes-4.4.0
xfce-extra/xfce4-fsguard-0.3.0
xfce-extra/xfce4-genmon-3.1
xfce-extra/xfce4-mailwatch-1.0.1
xfce-extra/xfce4-netload-0.4.0
xfce-extra/xfce4-sensors-0.10.0
xfce-extra/thunar-media-tags-0.1.2
xfce-extra/xfce4-timer-0.5.1
xfce-extra/xfce4-wavelan-0.5.4
xfce-extra/xfce4-xfapplet-0.1.0
xfce-extra/xfce4-xkb-0.4.3-r1

[Comment 1 Samuli Suominen (RETIRED) 2007-02-26 20:08:10 UTC]

eclass updated, ebuilds to go.

[Comment 2 Samuli Suominen (RETIRED) 2007-02-26 21:00:24 UTC]

ebuilds done. bug fixed. thank ye.