Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 168322 - sys-fs/udev is very noisy on non-modular kernels
Summary: sys-fs/udev is very noisy on non-modular kernels
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Core system (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: udev maintainers
URL:
Whiteboard:
Keywords:
: 171222 171237 183136 (view as bug list)
Depends on:
Blocks:
 
Reported: 2007-02-25 13:23 UTC by Tony Vroon (RETIRED)
Modified: 2007-06-25 11:47 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
udev-quiet-down.patch (udev-quiet-down.patch,308 bytes, patch)
2007-02-25 13:23 UTC, Tony Vroon (RETIRED)
Details | Diff
modprobe-104-r12.sh.diff (modprobe-104-r12.sh.diff,1.13 KB, patch)
2007-02-26 09:58 UTC, Jakub Moc (RETIRED)
Details | Diff
reincarnation of modprobe.sh fix (modprobe-104-r12-zzam.diff,1.64 KB, patch)
2007-02-26 10:41 UTC, Matthias Schwarzott
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tony Vroon (RETIRED) gentoo-dev 2007-02-25 13:23:28 UTC
At least udev 104-r12 (and perhaps some earlier revisions of 104 as well) is extremely noisy upon loading, spewing a complaint that modules.dep can not be found at least 20 times.
Please consider applying the patch below, which inhibits modprobe warnings by exiting from the modprobe.sh script as early as possible when a non-modular kernel is detected.
Comment 1 Tony Vroon (RETIRED) gentoo-dev 2007-02-25 13:23:55 UTC
Created attachment 111192 [details, diff]
udev-quiet-down.patch
Comment 2 Jakub Moc (RETIRED) gentoo-dev 2007-02-25 20:54:37 UTC
This will make Uberlord angry, as it's bash-specific. ;o) Also, -f doesn't feel right. How about something like this:

<snip>
if [ ! -e /proc/modules ]; then
	# Running kernel does not have a module loader
	exit 0
fi
</snip>
Comment 3 Matthias Schwarzott gentoo-dev 2007-02-25 21:43:04 UTC
[ -f /proc/modules ]
will work, as this IS a file.

modprobe.sh is not so problematic with respect to bash, as it is not directly sourced from the shell executing /sbin/rc.
Nevertheless we can convert it to bash (but at the moment there are more parts in it that are bash-specific).
Comment 4 Jakub Moc (RETIRED) gentoo-dev 2007-02-26 09:58:24 UTC
Created attachment 111264 [details, diff]
modprobe-104-r12.sh.diff

mkay, how about this? ;)
Comment 5 Matthias Schwarzott gentoo-dev 2007-02-26 10:41:58 UTC
Created attachment 111271 [details, diff]
reincarnation of modprobe.sh fix

This is my version of that patch.
It finally adds quoting for sh-tests.
Moved check for /proc/modules before loading /sbin/functions (discussable).
Rename variable LAST to MODNAME (as this is the real-name of the loaded module, that is printed for the user).
Comment 6 Matthias Schwarzott gentoo-dev 2007-03-02 13:21:56 UTC
Change applied to udev-105.ebuild.
Comment 7 Jakub Moc (RETIRED) gentoo-dev 2007-03-17 08:07:54 UTC
*** Bug 171222 has been marked as a duplicate of this bug. ***
Comment 8 Matthias Schwarzott gentoo-dev 2007-03-17 10:43:41 UTC
Backported the fix to udev-104-r12, to get it into 2007.0 release.
Comment 9 Jakub Moc (RETIRED) gentoo-dev 2007-03-17 12:26:40 UTC
*** Bug 171237 has been marked as a duplicate of this bug. ***
Comment 10 Jakub Moc (RETIRED) gentoo-dev 2007-06-25 11:47:54 UTC
*** Bug 183136 has been marked as a duplicate of this bug. ***