Bug 168257 – amarok-1.4.5-r1 doesn't compile on g/fbsd due to wrong #include directives

• Status: RESOLVED FIXED
• Product: Gentoo/Alt

[Description Emanuele A. Bagnaschi (Zephyrus) 2007-02-24 19:31:19 UTC]

amarok-1.4.5-r1 compilation fails, due to wrong #includes directives, with the following error:

In file included from fts1.c:23:
/usr/include/malloc.h:3:2: error: #error "<malloc.h> has been replaced by <stdlib.h>"

A quick look throughout the sources reveals that, in src/sqlite, there are three files which include malloc.h : fts1.c - fts1_porter.c - fts1_tokenizer1.c

The suggested fix is simple: #include <stdlib.h> instead of <malloc.h> on g/fbsd systems. The attached patch is based on the one included in the fbsd port.

[Comment 1 Emanuele A. Bagnaschi (Zephyrus) 2007-02-24 19:31:50 UTC]

Created attachment 111143 [details, diff]
mallo/stdlin includes patch for g/fbsd

[Comment 2 Dan 2007-03-16 23:10:31 UTC]

This should probably be filed upstream w/ sqlite, Amarok bundles a copy of sqlite libs so its their problem. 

[Comment 3 Diego Elio Pettenò (RETIRED) 2007-06-08 18:32:46 UTC]

This is fixed in 1.4.6_pre version.