Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 168051 - Global ebuild variables and pkg_setup
Summary: Global ebuild variables and pkg_setup
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal
Assignee: Gentoo Quality Assurance Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-02-22 22:31 UTC by Ciaran McCreesh
Modified: 2007-03-08 09:58 UTC (History)
5 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ciaran McCreesh 2007-02-22 22:31:45 UTC
Following on from "[gentoo-dev] Global ebuild variables and pkg_setup":

The following packages appear to misuse pkg_setup variables in globals. I've checked these by hand, but some false positives might have slipped past me...

Summary of herds:
  crypto dev-embedded embedded kernel media-tv mobile net-dialup no-herd sound

Summary of maintainers:
  <kingtaco@gentoo.org>
  <solar@gentoo.org>
  <sound@gentoo.org>
  Alessio Cassibba <swapon@gmail.com>
  Crypto Herd <crypto@gentoo.org>
  Daniel Black <dragonheart@gentoo.org>
  Markus Ullmann <jokey@gentoo.org>
  Peter Johanson <latexer@gentoo.org>
  Piotr Jaroszyński <peper@gentoo.org>
  Steev Klimaszewski <steev@gentoo.org>
  Stefan Schweizer <genstef@gentoo.org>

QA checks for package directory /app-crypt/tpm-emulator:
/app-crypt/tpm-emulator/tpm-emulator-0.2a.ebuild
  24: BUILD_PARAMS="-j1 CC=$(tc-getCC) MODULE=tpm_emulator.${KV_OBJ} USE_GMP=/usr/lib/libgmp.a"
/app-crypt/tpm-emulator/tpm-emulator-0.3.ebuild
  24: BUILD_PARAMS="-j1 CC=$(tc-getCC) MODULE=tpm_emulator.${KV_OBJ} USE_GMP=/usr/lib/libgmp.a"
herds: crypto
maintainer: Crypto Herd <crypto@gentoo.org>

QA checks for package directory /app-crypt/tpm-module:
/app-crypt/tpm-module/tpm-module-2.0.ebuild
  20: BUILD_PARAMS="KDIR=${KV_DIR}"
herds: crypto
maintainer: Daniel Black <dragonheart@gentoo.org>

QA checks for package directory /app-emulation/virtualbox:
/app-emulation/virtualbox/virtualbox-1.3.4-r1.ebuild
  35: BUILD_PARAMS="KERN_DIR=${KV_DIR} KERNOUT=${KV_OUT_DIR}"
/app-emulation/virtualbox/virtualbox-9999.ebuild
  32: BUILD_PARAMS="KERN_DIR=${KV_DIR} KERNOUT=${KV_OUT_DIR}"
herds: no-herd
maintainer: Markus Ullmann <jokey@gentoo.org>
maintainer: Alessio Cassibba <swapon@gmail.com>

QA checks for package directory /app-emulation/virtualbox-bin:
/app-emulation/virtualbox-bin/virtualbox-bin-1.3.4.ebuild
  44: BUILD_PARAMS="KERN_DIR=${KV_DIR} KERNOUT=${KV_OUT_DIR}"
herds: no-herd
maintainer: Markus Ullmann <jokey@gentoo.org>
maintainer: Alessio Cassibba <swapon@gmail.com>

QA checks for package directory /app-laptop/thinkpad:
/app-laptop/thinkpad/thinkpad-5.9-r1.ebuild
  18: BUILD_PARAMS="KSRC=${KV_DIR}"
herds: mobile
maintainer: Steev Klimaszewski <steev@gentoo.org>

QA checks for package directory /dev-embedded/gpio:
/dev-embedded/gpio/gpio-1.3.2.ebuild
  18: BUILD_PARAMS="KERNELDIR=${KV_DIR}"
herds: embedded
maintainer: <solar@gentoo.org>

QA checks for package directory /dev-embedded/parapin-driver:
/dev-embedded/parapin-driver/parapin-driver-1.0.0.ebuild
  22: BUILD_PARAMS="CC=$(tc-getCC) LINUX_SRC=${KV_DIR} -C .."
herds: dev-embedded

QA checks for package directory /media-tv/rivatv:
/media-tv/rivatv/rivatv-0.8.6-r1.ebuild
  23: BUILD_PARAMS="KSRC=${ROOT}${KV_DIR} KVERS=${KV_MAJOR}${KV_MINOR}"
/media-tv/rivatv/rivatv-0.8.6.ebuild
  22: BUILD_PARAMS="KSRC=${ROOT}${KV_DIR} KVERS=${KV_MAJOR}${KV_MINOR}"
herds: media-tv

QA checks for package directory /media-video/spca5xx:
/media-video/spca5xx/spca5xx-20060202.ebuild
  19: BUILD_PARAMS="KERNELDIR=${KV_DIR}"
/media-video/spca5xx/spca5xx-20060301.ebuild
  19: BUILD_PARAMS="KERNELDIR=${KV_DIR}"
/media-video/spca5xx/spca5xx-20060402.ebuild
  19: BUILD_PARAMS="KERNELDIR=${KV_DIR}"
herds: no-herd
maintainer: <kingtaco@gentoo.org>

QA checks for package directory /net-dialup/bewan-adsl:
/net-dialup/bewan-adsl/bewan-adsl-0.9.3-r2.ebuild
  24: BUILD_PARAMS="KERNEL_SOURCES=${KV_DIR} KVERS=${KV_FULL}"
herds: net-dialup

QA checks for package directory /net-dialup/eagle-usb:
/net-dialup/eagle-usb/eagle-usb-2.3.3.ebuild
  22: BUILD_PARAMS="KERNELSRC='${KV_DIR}'"
herds: net-dialup

QA checks for package directory /net-dialup/ltmodem:
/net-dialup/ltmodem/ltmodem-8.31_alpha10-r3.ebuild
  28: BUILD_PARAMS="KERNEL_DIR='${KV_DIR}'"
herds: net-dialup

QA checks for package directory /net-misc/arpstar:
/net-misc/arpstar/arpstar-0.5.5-r1.ebuild
  19: BUILD_PARAMS="KDIR=${KV_DIR}"
herds: kernel

QA checks for package directory /net-wireless/ndiswrapper:
/net-wireless/ndiswrapper/ndiswrapper-1.33.ebuild
  22: BUILD_PARAMS="KSRC=${ROOT}${KV_DIR} KVERS=${KV_FULL}"
/net-wireless/ndiswrapper/ndiswrapper-1.34.ebuild
  22: BUILD_PARAMS="KSRC=${ROOT}${KV_DIR} KVERS=${KV_FULL}"
/net-wireless/ndiswrapper/ndiswrapper-1.35.ebuild
  22: BUILD_PARAMS="KSRC=${ROOT}${KV_DIR} KVERS=${KV_FULL}"
/net-wireless/ndiswrapper/ndiswrapper-1.36.ebuild
  22: BUILD_PARAMS="KSRC=${ROOT}${KV_DIR} KVERS=${KV_FULL}"
/net-wireless/ndiswrapper/ndiswrapper-1.37.ebuild
  22: BUILD_PARAMS="KSRC=${ROOT}${KV_DIR} KVERS=${KV_FULL}"
herds: mobile
maintainer: Piotr Jaroszyński <peper@gentoo.org>

QA checks for package directory /net-wireless/prism54:
/net-wireless/prism54/prism54-20050125.ebuild
  19: BUILD_PARAMS="KVER=${KV_FULL} KDIR=${KV_DIR}"
herds: mobile
maintainer: Peter Johanson <latexer@gentoo.org>

QA checks for package directory /sys-apps/realtime-lsm:
/sys-apps/realtime-lsm/realtime-lsm-0.8.5-r1.ebuild
  20: BUILD_PARAMS="KSRC=${ROOT}${KV_DIR} TOUT=${TMP}/tmp-gas-check"
herds: sound
maintainer: <sound@gentoo.org>

QA checks for package directory /sys-fs/cowloop:
/sys-fs/cowloop/cowloop-1.4.ebuild
  20: BUILD_PARAMS="-C ${KV_DIR} SUBDIRS=${S} -I."
/sys-fs/cowloop/cowloop-2.14.ebuild
  18: BUILD_PARAMS="-C ${KV_DIR} SUBDIRS=${S} -I."
/sys-fs/cowloop/cowloop-2.15-r1.ebuild
  18: BUILD_PARAMS="-C ${KV_DIR} SUBDIRS=${S} -I."
/sys-fs/cowloop/cowloop-3.0-r1.ebuild
  19: BUILD_PARAMS="-C ${KV_DIR} SUBDIRS=${S} -I."
herds: no-herd
maintainer: Daniel Black <dragonheart@gentoo.org>

QA checks for package directory /sys-fs/fuse:
/sys-fs/fuse/fuse-2.6.0.ebuild
  19: BUILD_PARAMS="majver=${KV_MAJOR}.${KV_MINOR}
  22: ECONF_PARAMS="--with-kernel=${KV_DIR} --with-kernel-build=${KV_OUT_DIR}"
/sys-fs/fuse/fuse-2.6.0_rc1.ebuild
  19: BUILD_PARAMS="majver=${KV_MAJOR}.${KV_MINOR}
  22: ECONF_PARAMS="--with-kernel=${KV_DIR} --with-kernel-build=${KV_OUT_DIR}"
/sys-fs/fuse/fuse-2.6.1.ebuild
  19: BUILD_PARAMS="majver=${KV_MAJOR}.${KV_MINOR}
  22: ECONF_PARAMS="--with-kernel=${KV_DIR} --with-kernel-build=${KV_OUT_DIR}"
/sys-fs/fuse/fuse-2.6.3.ebuild
  19: BUILD_PARAMS="majver=${KV_MAJOR}.${KV_MINOR}
  22: ECONF_PARAMS="--with-kernel=${KV_DIR} --with-kernel-build=${KV_OUT_DIR}"
herds: kernel
maintainer: Stefan Schweizer <genstef@gentoo.org>
Comment 1 Stefan Schweizer (RETIRED) gentoo-dev 2007-02-23 12:25:18 UTC
sys-fs/fuse fixed.
Comment 2 Doug Goldstein (RETIRED) gentoo-dev 2007-02-23 14:07:53 UTC
rivatv is masked and being removed March 6th. It has a lot more issues then just this, it won't be fixed.
Comment 3 Alon Bar-Lev (RETIRED) gentoo-dev 2007-02-23 15:45:12 UTC
crypto done.

Listed:
app-crypt/tpm-emulator
app-crypt/tpm-modules

And none listed:
sys-fs/loop-aes
sys-fs/dazuko
Comment 4 Piotr Jaroszyński (RETIRED) gentoo-dev 2007-02-23 15:57:23 UTC
Thanks, net-wireless/ndiswrapper done.
Comment 5 solar (RETIRED) gentoo-dev 2007-02-24 10:16:06 UTC
there was no clear decision on global variables. Till there is one this bug is bogus and only for the benefit of other pkg mgrs and shouyld have nothing to do with QA. Closing...
Comment 6 Stephen Bennett (RETIRED) gentoo-dev 2007-02-24 13:52:43 UTC
There was a fairly clear consensus that the behaviour which enables this to work is undesirable and shouldn't be relied upon.
Comment 7 Stefan Schweizer (RETIRED) gentoo-dev 2007-02-25 09:09:24 UTC
thinkpad and prism54 fixed.
Comment 8 Stefan Schweizer (RETIRED) gentoo-dev 2007-02-25 09:16:47 UTC
net-dialup/bewan-adsl,eagle-usb and ltmodem fixed
Comment 9 Stefan Schweizer (RETIRED) gentoo-dev 2007-02-25 09:40:03 UTC
arpstar, virtualbox and realtime-lsm fixed
Comment 10 Stefan Schweizer (RETIRED) gentoo-dev 2007-02-25 09:43:43 UTC
cowloop fixed too.
Comment 11 Stefan Schweizer (RETIRED) gentoo-dev 2007-02-25 09:44:43 UTC
remove fixed from CC
Comment 12 Stefan Schweizer (RETIRED) gentoo-dev 2007-03-08 09:58:02 UTC
fixed all the remaining violations. Please notifx me if any new ones come up. I hope in portage the multiple sourcing of ebuild bug will get fixed soon so that devs can see this themselves ..