Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 167944 - [science overlay] sci-libs/cgal-3.2.1 (new ebuild)
Summary: [science overlay] sci-libs/cgal-3.2.1 (new ebuild)
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Gentoo Science Mathematics related packages
URL: http://www.cgal.org
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-02-22 02:09 UTC by kaouete
Modified: 2008-10-27 15:43 UTC (History)
5 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
cgal-3.2.1.ebuild (cgal-3.2.1.ebuild,3.53 KB, text/plain)
2008-01-29 13:14 UTC, Piotr Szymaniak
Details
cgal-3.3.1.ebuild (cgal-3.3.1.ebuild,3.49 KB, text/plain)
2008-04-12 23:37 UTC, Eric Huang
Details

Note You need to log in before you can comment on or make changes to this bug.
Description kaouete 2007-02-22 02:09:27 UTC
hi,

Please consider an ebuild for CGAL.

http://www.cgal.org

Thanks :)

Reproducible: Always
Comment 1 FENOY Gérald (RETIRED) gentoo-dev 2007-04-26 12:09:08 UTC
Since 4 months the CGAL ebuild (as its python support) is available on the gentooscience overlay (http://gentooscience.org/).
Comment 2 Raphael 2007-04-30 21:18:23 UTC
It is masked by: missing keyword in that overlay and gentooscience is not even available through layman it seems.

It would be great to get this well respected library a bit more mainstream in gentoo.

Raphael

Comment 3 Piotr Szymaniak 2008-01-29 13:14:05 UTC
Created attachment 142109 [details]
cgal-3.2.1.ebuild

http://gentooscience.org/ looks dead, here's the ebuild.
Comment 4 Radek Podgorny 2008-03-13 14:48:18 UTC
(In reply to comment #1)
> Since 4 months the CGAL ebuild (as its python support) is available on the
> gentooscience overlay (http://gentooscience.org/).
> 

Anyone saved the python ebuild?
Comment 5 Sébastien Fabbro (RETIRED) gentoo-dev 2008-03-13 14:59:10 UTC
Hi,

gentooscience was transfered. See http://overlays.gentoo.org/proj/science
layman -a science works nicely.

Anyway the cgal ebuilds need work and bumps. We may do this hopefully soon, but you can accelerate the process if you have any change/fix/bump that you want to submit here.

Thanks!

Comment 6 Eric Huang 2008-04-12 23:37:14 UTC
Created attachment 149527 [details]
cgal-3.3.1.ebuild

Version bump to 3.3.1, fixing several issues. This is my first ebuild so please scrutinize it!
Comment 7 Sébastien Fabbro (RETIRED) gentoo-dev 2008-04-20 09:49:30 UTC
Hi Eric,

Thanks a lot for your efforts taking over the cgal ebuild. 
This is a long overdue package we should include in portage. 
Here are some comments to improve the ebuild. Most of them also applied to the earlier version.

>DESCRIPTION="The Computational Geometry Algorithms Library is an Open
>Source C++ library of geometric algorithms and data structures."

Shorter description (less than 80 or 100 characters)

>HOMEPAGE="http://www.cgal.org/"
>DLPAGE="http://www.cgal.org/download/"
>PKN="$(echo ${PN} | tr {a-z} {A-Z})"
>PK="$(echo ${P} | tr {a-z} {A-Z})"
>SRC_URI="${PK}.tar.gz"
>#SRC_URI="ftp://ftp.mpi-sb.mpg.de/pub/outgoing/${PKN}/${PK}.tar.gz"
[...]
>RESTRICT="fetch"

Probably don't need all these variables. 
Fetching restricted is pretty annoying. Do we really need it? LGPL-2.1 and QPL don't restrict this.
Do you think mirror restricting could be enough? 

>LICENSE="LGPL-2 QPL"

Of what I see in the web page, this is lesser-GPL, not library-GPL. As such it is probably LGPL-2.1.


>DEPEND="zlib? ( sys-libs/zlib )
>	qt3? ( $(qt_min_version 3.0) )
>	examples? ( $(qt_min_version 3.0) )
>	X? ( x11-libs/libX11 )
>	sci-libs/libcore
>	dev-libs/gmp
>	dev-libs/mpfr
>	=dev-libs/boost-1.32"

RDEPEND is DEPEND by default. Do we need all these deps in RDEPEND (I'm thinking of boost, which consists mostly of headers)
Also do we compile the examples? If not, qt is probably not needed for them.

>	unpack "${A}"

Remove quotes.

>	use X && myconf="${myconf} --with-x11"
>	use zlib && myconf="${myconf} --with-zlib"
>	if use qt3 || use examples; then
>		myconf="${myconf} --with-qt3mt --qt_incl_dir ${QTDIR}/include/ \
>			--qt_lib_dir ${QTDIR}/lib"
>	fi

Make sure that when these use flags are *not* set, the install script does not automatically find the libraries. In other words, that you don't need to specify the equivalent of --without-X11.

>	./install_cgal ${myconf} -ni $(which $(tc-getCXX)) || \
>		die "Unable to compile"

If you really need "which", use the more portabe "type -P" instead.


>	find "${SDIR}" -name \*.a -exec dolib.a {} \;
>	find "${SDIR}" -name \*.so.2.0.1 -exec dolib.so {} \;
>
>	# Make symlinks from *.so to *.so.2.0.1
>
>	for FILE in `find "${SDIR}" -name "*\.so\.2\.0\.1" -exec basename {} \;`; do
>		dosym 	"${FILE}" \
>			"./usr/lib/$(echo ${FILE} | sed 's/\.2\.0\.1$//')" || \
>			die "Unable to create symlinks"
>	done

Try avoiding hardcoded soversions such as 2.0.1, this is not easily maintainable. 
The dosym does not need the "." in ./usr, replace lib with $(get_libdir) from the multilib eclass.

>	CGALINC="${CGALDIR}/include/"
>	cp -rp "${CGALINC}" "${D}/usr/" || \
>		die "Unable to install headers"

Use insinto/doins -r instead.

>	dodir "/usr/share/CGAL" || die "Unable to create share directory"
>	cp "${CGALDIR}/share/cgal/cgal.mk" "${D}/usr/share/CGAL/makefile" || \
>		die "Unable to install makefile"

same.


>	if use examples; then
>		dodir /usr/share/doc/${P}
>		cp -r "${S}/demo" "${D}/usr/share/doc/${P}"
>		cp -r "${S}/examples" "${D}/usr/share/doc/${P}"

Use ${PF} instead of ${P}, and insinto/doins instead of dodir/cp.

Next:
* Make sure all use flags/deps are set (I see some lapack in their web page)
* Make sure text doc files (such as AUTHORS, README) are dodoc'ed
* Might want to check other Linux and BSD distribs for possible patches and cross-checks.
* Include a src_test if the default one does not work.

Thanks!
Comment 8 Renato Caldas 2008-10-18 13:21:40 UTC
Additionally, portage has been giving me this error:

* sci-libs/cgal-3.2.1: qt_min_version() is deprecated. Use slot dependencies instead.

I'm not using cgal, but this should be fixed.

BTW, why isn't science being updated?
Comment 9 Sébastien Fabbro (RETIRED) gentoo-dev 2008-10-27 15:43:08 UTC
cgal-3.3.1 in now main tree.
Thanks all.