Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 167703 - USE="-doc" seems to be useless when emerging *-sources
Summary: USE="-doc" seems to be useless when emerging *-sources
Status: RESOLVED FIXED
Alias: None
Product: [OLD] Docs on www.gentoo.org
Classification: Unclassified
Component: Installation Handbook (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: nm (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-02-20 00:23 UTC by Ewoud Kohl van Wijngaarden
Modified: 2007-02-26 08:59 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ewoud Kohl van Wijngaarden 2007-02-20 00:23:49 UTC
In http://www.gentoo.org/doc/en/handbook/handbook-x86.xml?part=1&chap=7#doc_chap2 you suggest to do:
USE="-doc symlink" emerge gentoo-sources
which seems useless to me. First of all there is no doc-useflag.
Second, the symlink gets created automaticly when there is no /usr/src/linux (tested with a fresh install and gentoo-sources-2.6.19-r5). Removing the symlink-useflag also fixes that you remerge the first time you do emerge -uDN world you also remerge gentoo-sources while it changes nothing and might confuse people who're new to gentoo. And emerging this way isn't "the gentoo way"(tm).
Comment 1 Xavier Neys (RETIRED) gentoo-dev 2007-02-20 00:29:16 UTC
-doc and note will be removed after having checked
symlink should remain. Search cvs logs/bugs.g.o if you feel like it
Comment 2 nm (RETIRED) gentoo-dev 2007-02-21 21:26:22 UTC
(In reply to comment #1)
> -doc and note will be removed after having checked
> symlink should remain. Search cvs logs/bugs.g.o if you feel like it
> 

I read through kernel-2.eclass, and it looks like lines 610 - 628 do indeed symlink the kernel with or without the USE flag on a fresh install.
Comment 3 nm (RETIRED) gentoo-dev 2007-02-21 21:27:16 UTC
CCing our kernel gurus to confirm that this is what the eclass does.
Comment 4 Xavier Neys (RETIRED) gentoo-dev 2007-02-21 23:20:12 UTC
(In reply to comment #2)
> I read through kernel-2.eclass, and it looks like lines 610 - 628 do indeed
> symlink the kernel with or without the USE flag on a fresh install.

Of course it does, still not a reason to remove it. Handbook is very clear about symlink.

It looks like no kernel uses doc anymore and this one can be safely removed.
Comment 5 nm (RETIRED) gentoo-dev 2007-02-22 03:16:55 UTC
(In reply to comment #4)
> Of course it does, still not a reason to remove it. Handbook is very clear
> about symlink.
> 
> It looks like no kernel uses doc anymore and this one can be safely removed.

Correct, -doc can be removed. However, dsd will be removing the symlink USE flag, as he and the kernel team feel that its behavior is unnecessary and broken (in some situations). Therefore, I'd like to remove it from the handbook as well. As the handbook says, it's not necessary -- in fact just emerging a kernel package _does_ "ensure proper creation of the /usr/src/linux symlink."

Therefore, why keep it if you already get it? Such redundancy is unneeded, because the handbook's procedure is assuming a first-time install, with no preexisting symlink.
Comment 6 Xavier Neys (RETIRED) gentoo-dev 2007-02-23 09:50:57 UTC
(In reply to comment #5)
> (In reply to comment #4)
> > Of course it does, still not a reason to remove it. Handbook is very clear
> > about symlink.
> > 
> > It looks like no kernel uses doc anymore and this one can be safely removed.
> 
> Correct, -doc can be removed.

Good.

> However, dsd will be removing the symlink USE
> flag, as he and the kernel team feel that its behavior is unnecessary and
> broken (in some situations). Therefore, I'd like to remove it from the handbook
> as well. As the handbook says, it's not necessary -- in fact just emerging a
> kernel package _does_ "ensure proper creation of the /usr/src/linux symlink."
> 
> Therefore, why keep it if you already get it? Such redundancy is unneeded,
> because the handbook's procedure is assuming a first-time install, with no
> preexisting symlink.

Funny, you didn't object when you wrote the patch. Bug #118031
We'll have to remove the flag when it has disappeared.
Is it the symlink USE flag that will be removed from the kernel packages, or the symlink behaviour? What are we gonna get? No more symlink? Symlink on first kernel package only? Always symlink to last emerged kernel?
Comment 7 nm (RETIRED) gentoo-dev 2007-02-23 10:48:51 UTC
(In reply to comment #6)
> Funny, you didn't object when you wrote the patch. Bug #118031

Eh, it was going to be included; I saw the need to help, so I did it.

> We'll have to remove the flag when it has disappeared.
> Is it the symlink USE flag that will be removed from the kernel packages, or
> the symlink behaviour?

The USE flag itself will be removed from the packages. I'd hope that the behavior wouldn't change at all, as it works quite nicely as-is: fresh install, it symlinks for you, but remerging or upgrading means the user still has to run eselect or ln -sfn.

Kernel team, you guys planning any actual behavior change, or can I go ahead and remove USE="-doc symlink" from the doc right now?
Comment 8 Daniel Drake (RETIRED) gentoo-dev 2007-02-23 14:21:44 UTC
you can remove it
Comment 9 nm (RETIRED) gentoo-dev 2007-02-26 08:59:17 UTC
Thanks for reporting, fixed in CVS. Also, dsd requested that symlink be removed as an integral part of taking out the USE flag from the ebuilds themselves.