Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 167455 - net-news/liferea should have a lua dep and use-flag
Summary: net-news/liferea should have a lua dep and use-flag
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Daniel Gryniewicz (RETIRED)
URL:
Whiteboard:
Keywords:
: 180700 (view as bug list)
Depends on:
Blocks:
 
Reported: 2007-02-18 10:49 UTC by srrijkers
Modified: 2007-06-05 01:45 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
adds lua flag. (liferea-1.2.15-luause.patch,1.20 KB, patch)
2007-06-04 22:23 UTC, Pietro Franchi
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description srrijkers 2007-02-18 10:49:52 UTC
Recently, the net-news/liferea-1.2.6b ebuild was modified to not enable lua scripting support because of a compilation failure (#166596). While not having dev-lang/lua installed may not have resulted in a compilation failure in previous versions, it made them malfunction as well, as the "Program/Script Manager" entry would not work. To make lua support in liferea functional and optional, I suggest the following:

- add an IUSE for lua
- add a dependency on dev-lang/lua based on this flag
- add the $(use_enable lua) bit when configuring
Comment 1 Jakub Moc (RETIRED) gentoo-dev 2007-02-18 10:52:17 UTC
Not while it breaks compile.


*** This bug has been marked as a duplicate of bug 166596 ***
Comment 2 srrijkers 2007-02-18 10:55:57 UTC
Enabling lua does not break compilation if dev-lang/lua (or at least version 5.1.1) is installed, which is why I am requesting the added dependency as well.
Comment 3 Daniel Gryniewicz (RETIRED) gentoo-dev 2007-02-19 15:53:32 UTC
I'll look into a use flag...
Comment 4 Daniel Gryniewicz (RETIRED) gentoo-dev 2007-02-22 18:45:42 UTC
For now, I'm not adding a lua use flag.  I don't particularly want to install and test with lua, which I'd have to do if there was a use flag.  1.2.7 is in the tree, and the lua checks are fixed, so if you have lua, it will build support for it, similar to how networkmanager support is now.  In the future, if there is some need, I'll revisit a lua use flag.
Comment 5 Jakub Moc (RETIRED) gentoo-dev 2007-06-03 09:36:42 UTC
*** Bug 180700 has been marked as a duplicate of this bug. ***
Comment 6 Jakub Moc (RETIRED) gentoo-dev 2007-06-03 09:37:51 UTC
(In reply to comment #4)
> and the lua checks are fixed, so if you have lua, it will build
> support for it, similar to how networkmanager support is now.  In the future,
> if there is some need, I'll revisit a lua use flag.

http://www.gentoo.org/proj/en/qa/automagic.xml

Reopening.
Comment 7 Pietro Franchi 2007-06-04 22:23:58 UTC
Created attachment 121201 [details, diff]
adds lua flag.

This patch will pass --disable-lua to the configure if the lua flag is not set.
Comment 8 Daniel Gryniewicz (RETIRED) gentoo-dev 2007-06-05 01:45:49 UTC
1.2.16 has a lua flag.