Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 167172 - dev-util/meld traceback on unreadable files
Summary: dev-util/meld traceback on unreadable files
Status: RESOLVED UPSTREAM
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo Linux Gnome Desktop Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-02-16 09:44 UTC by Michał Wiernowolski
Modified: 2007-02-16 17:10 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Wiernowolski 2007-02-16 09:44:03 UTC
Meld stops at the first file for which the user has no rights to read.
The GUI works, but the list of files is empty.

Below you will find original traceback ("Brak dostępu"=="Access denied").

Traceback (most recent call last):
  File "/usr/lib/meld/task.py", line 131, in iteration
    ret = task()
  File "/usr/lib/meld/dirdiff.py", line 461, in _search_recursively_iter
    allfiles = self._filter_on_state( roots, accumfiles.get() )
  File "/usr/lib/meld/dirdiff.py", line 742, in _filter_on_state
    if _files_same( curfiles, self.regexes ):
  File "/usr/lib/meld/dirdiff.py", line 91, in _files_same
    contents = [ open(f, "r").read() for f in lof ]
IOError: [Errno 13] Brak dostępu: '/etc/.pwd.lock'

Reproducible: Always

Steps to Reproduce:
1.As root make a backup of /etc
2.Compare /etc with the backup as a non-root user
Comment 1 Daniel Gryniewicz (RETIRED) gentoo-dev 2007-02-16 15:35:23 UTC
Do you have meld 1.1.4?  When i do this with that version of meld, I get a pop-up dialog saying "Could no read from foo permission denied".
Comment 2 Michał Wiernowolski 2007-02-16 16:28:37 UTC
(In reply to comment #1)
> Do you have meld 1.1.4?  When i do this with that version of meld, I get a
> pop-up dialog saying "Could no read from foo permission denied".
> 

I have meld 1.1.4.
The popup dialog appears when you start it from the menu, which I never do.
To get the traceback you should start it from the console, like this
    meld /etc/ /mnt/z/gentoo.backup/etc/

In either case the parser stops and you have an incomplete list of files.
Comment 3 Daniel Gryniewicz (RETIRED) gentoo-dev 2007-02-16 16:47:29 UTC
I get the popup when I start it from the console; regardless, what do you want it to do?  It can't read the files.
Comment 4 Michał Wiernowolski 2007-02-16 17:02:59 UTC
(In reply to comment #3)
> I get the popup when I start it from the console; regardless, what do you want
> it to do?  It can't read the files.
> 

If this is unclear I am talking about directories, not single files.
If you compare single files then an error message is enough.
If you compare directories then the files which can't be read should be skipped  and preferably marked somehow in the listing.
In case of /etc I get an empty list, although there are lots of files which are readable and can be compared.
Comment 5 Daniel Gryniewicz (RETIRED) gentoo-dev 2007-02-16 17:10:00 UTC
Okay, I would classify this as a feature request, then, rather than a bug; it should be taken upstream to http://meld.sourceforge.net/ as none of us have specific expertise in meld.