Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 166897 - sci-electronics/spice-3.5.5: when compilation fails, portage installs broken package
Summary: sci-electronics/spice-3.5.5: when compilation fails, portage installs broken ...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All All
: High major (vote)
Assignee: The Soldering-Iron Brotherhood
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-02-14 20:03 UTC by David Watzke
Modified: 2007-03-12 18:38 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description David Watzke 2007-02-14 20:03:56 UTC
When compilation of sci-electronics/spice-3.5.5 fails (*this* was someone's PEBKAC, so this is *not* the reason of this bug), portage installs broken package(!), because ./util/build won't exit with exit-status 1 even if it fails. I'd recommend adding something like this:

|| die "dobin failed"

after dobin at least. Better would be fix the build-script, because it is broken, but I don't know how, so I can't help (yet).

You can also inherit fixheadtails eclass and run this after epatching:

ht_fix_file util/build

because it uses old head/tail syntax.
Comment 1 Denis Dupeyron (RETIRED) gentoo-dev 2007-03-12 18:38:42 UTC
(In reply to comment #0)
[...]
> I'd recommend adding something like this:
> 
> || die "dobin failed"
> 
> after dobin at least. Better would be fix the build-script, because it is
> broken, but I don't know how, so I can't help (yet).

Fixed, thanks.

> You can also inherit fixheadtails eclass and run this after epatching:
> 
> ht_fix_file util/build
> 
> because it uses old head/tail syntax.

Fixed too, but using a simple sed instead. This way, if the fixheadtail eclass needs to be removed some day, this package won't be an issue.

Also, I have fixed some rather ugly issue with the mtime of the unpacked source directory which forced WORKDIR to be recreated each time you issue an 'ebuild <command>'. What happens is that the files that were previously built are then missing from ${WORKDIR}, but the .compiled file is still there in ${PORTAGE_TMPDIR}/portage/${PF}, thus nothing is recompiled and installation fails. This may have been the root cause of your installation failure above if you installed using step-by-step ebuild commands instead of emerge.

By the way, do that 'someone' a favor, and tell him/her to use gnucap, or at the very least ngspice, instead of ancient spice. ;o)

Thanks for your (interesting) bug report.
Denis.