Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 166630 - java-pkg-2_src_compile is unable to handle the situation when a ebuild has *IUSE=doc but does not contain a doc producing target within its build.xml
Summary: java-pkg-2_src_compile is unable to handle the situation when a ebuild has *I...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Eclasses (show other bugs)
Hardware: All Linux
: High trivial (vote)
Assignee: Java team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-02-13 09:32 UTC by Alistair Bush (RETIRED)
Modified: 2007-05-07 22:11 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
dev-java/jarbundler-1.4-r2.ebuild which will fail when doc use flag set (jarbundler-1.4-r2.ebuild,718 bytes, text/plain)
2007-02-13 09:54 UTC, Alistair Bush (RETIRED)
Details
possible solution (java-pkg-2.eclass.patch,1.43 KB, patch)
2007-02-13 14:00 UTC, Vlastimil Babka (Caster) (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alistair Bush (RETIRED) gentoo-dev 2007-02-13 09:32:59 UTC
In the situation where a java package does not have a target for producing documentation, but does bundle documentation there is currently no way for an ebuild to inherit the functionality within java-pkg-2_src_compile.

This is a result of java-pkg-2_src_compile using use_doc which outputs 'javadoc' if ${1} is empty.


dev-java/jarbundler-1.4.ebuild within the migrated-java-experimental-overlay demonstrates this error.


I also apologies for the incoherent ramble that is the above. I have discussed this issue with Caster.
Comment 1 Alistair Bush (RETIRED) gentoo-dev 2007-02-13 09:54:29 UTC
Created attachment 110046 [details]
dev-java/jarbundler-1.4-r2.ebuild which will fail when doc use flag set

test ebuild within overlay is now jarbundler-1.4-r2.ebuild
Comment 2 Vlastimil Babka (Caster) (RETIRED) gentoo-dev 2007-02-13 14:00:41 UTC
Created attachment 110059 [details, diff]
possible solution

Allows declaring EANT_DOC_TARGET="" in ebuild to skip the use_doc part. IMHO better than adding another EANT_DISABLE_DOC-like variable. The downside is that it now has own default value "javadoc" and isn't relying on use_doc default... but I don't think we're ever gonna change the default... Didn't see any easy way to test for "variable declared but empty", but maybe somebody else can come up with better solution.
Comment 3 Petteri Räty (RETIRED) gentoo-dev 2007-02-13 16:38:15 UTC
Sometimes we just need to stop and think about over engineering. What is wrong with just:

src_compile() {
    eant
}

Comment 4 Vlastimil Babka (Caster) (RETIRED) gentoo-dev 2007-02-14 22:38:51 UTC
Considering how many variables are already there for default src_compile(), this small change doesn't add too much IMHO (at least not another variable).
Comment 5 Petteri Räty (RETIRED) gentoo-dev 2007-05-07 21:49:01 UTC
(In reply to comment #4)
> Considering how many variables are already there for default src_compile(),
> this small change doesn't add too much IMHO (at least not another variable).
> 

sure. I don't object to adding it but am not going to do it myself.
Comment 6 Vlastimil Babka (Caster) (RETIRED) gentoo-dev 2007-05-07 22:11:28 UTC
in cvs