Bug 166596 – net-news/liferea-1.2.6b misses lua dependency

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Rafal Boniecki 2007-02-12 23:32:06 UTC]

net-news/liferea-1.2.6b ebuild is broken because we do not check for lua.

Reproducible: Always

Steps to Reproduce:
1. emerge liferea on ~x86 system

[Comment 1 Rafal Boniecki 2007-02-12 23:33:49 UTC]

Created attachment 110012 [details]
fixed ebuild

[Comment 2 Rafal Boniecki 2007-02-12 23:35:27 UTC]

Steps to Reproduce should be:
1. emerge net-news/liferea on ~x86 system without dev-lang/lua installed

[Comment 3 Aurélien Bauchet 2007-02-13 11:01:36 UTC]

I confirm

Ebuild broken when emerging without dev-lang/lua installed.

Steps to Reproduce as Rafal said:
1. emerge net-news/liferea on ~x86 system without dev-lang/lua installed

[Comment 4 Peter Volkov (RETIRED) 2007-02-13 12:03:24 UTC]

Thank you for the fix, Rafal. I'm not from the gnome team, thus I just drop here two general notes. Please, attach diff here instead of full ebuild (make easier to review your changes) and instead of

	if use lua ; then
		G2CONF="${G2CONF} --enable-lua"
	else
		G2CONF="${G2CONF} --disable-lua"
	fi

it's better to use G2CONF="${G2CONF} $(use_enable lua)" because it's cleaner and easier to read. See `man 5 ebuild` for details on use_enable.

[Comment 5 Rafal Boniecki 2007-02-13 12:29:44 UTC]

Thanks for tips :). See attachment below for a patch.

[Comment 6 Rafal Boniecki 2007-02-13 12:30:22 UTC]

Created attachment 110054 [details, diff]
liferea-1.2.6b ebuild patch

[Comment 7 Daniel Gryniewicz (RETIRED) 2007-02-13 18:38:00 UTC]

I've just disabled lua for now.

[Comment 8 Jakub Moc (RETIRED) 2007-02-18 10:52:17 UTC]

*** Bug 167455 has been marked as a duplicate of this bug. ***