Bug 16627 – samba compile fix

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Maurice van der Pot (RETIRED) 2003-03-01 12:24:26 UTC]

During compilation of samba 2.2.8_pre1, I got these errors:

smbwrapper/smbw.c:1523: warning: no semicolon at end of struct or union
smbwrapper/smbw.c:1523: parse error before '.' token
smbwrapper/smbw.c:1525: parse error before '.' token
smbwrapper/smbw.c:1527: parse error before '.' token
smbwrapper/smbw.c:1531: parse error before '}' token
and then some

After some digging I found out that a structure is defined in smbw.c
(kernel_stat) which will be used to hold the same information as the kernel stat
struct. This structure (in samba) is defined to have a member called st_atime
which is defined in my header file bits/stat.h as follows:

# define st_atime st_atim.tv_sec        /* Backward compatibility.  */         
                                                                               
                   

This causes the parse error.


Reproducible: Always
Steps to Reproduce:
I am not sure what combination of packages/use flags causes this to go wrong,
but once it goes wrong, all that is needed to get the error again is try to
emerge samba 2.2.8_pre1.
Actual Results:  
Parse error while compiling smbw.c


Portage 2.0.47-r6 (default-x86-1.4, gcc-3.2.2, glibc-2.3.2_pre1-r0)
=================================================================
System uname: 2.4.19 i686 Pentium III (Coppermine)
GENTOO_MIRRORS="ftp://ftp.nluug.nl/pub/metalab/distributions/gentoo
http://gentoo.oregonstate.edu/
http://www.ibiblio.org/pub/Linux/distributions/gentoo"
CONFIG_PROTECT="/etc /var/qmail/control /usr/kde/2/share/config
/usr/X11R6/lib/X11/xkb /usr/kde/3/share/config /usr/share/config"
CONFIG_PROTECT_MASK="/etc/gconf /etc/env.d"
PORTDIR="/usr/portage"
DISTDIR="/usr/portage/distfiles"
PKGDIR="/usr/portage/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR_OVERLAY=""
USE="qtmt -3dfx -3dnow -aalib -acl -acpi -afs alsa apache2 -apm -arts -atlas avi
-berkdb bonobo -canna cdr -cjk crypt -cups dga directfb -doc dvd encode -esd
ethereal -evo -ev6 -fbcon -flash -freewnn -gb gd gdbm ggi gif -gnome -gphoto2
gpm -gps gtk gtk2 -gtkhtml -guile -icc -icc-pgo imap imlib -innodb ipv6 java
-jikes jpeg -junit -kde -kerberos -lcms -ldap -leim -libg++ -libgda libwww
-matrox maildir mbox mikmod mmx -motif mozilla mpeg -mule mysql -nas ncurses
-nls -nocardbus oav -oci8 -odbc oggvorbis opengl oss pam -pcmcia -pda pdflib
perl pic plotutils png pnp python qt quicktime readline -ruby samba sasl
-scanner sdl slang -slp snmp -socks5 spell sse ssl svga tcltk tcpd -tetex tiff
truetype trusted usb -voodoo3 -wavelan wmf X -xface xml xml2 xmms xv -zeo zlib x86"
COMPILER="gcc3"
CHOST="i686-pc-linux-gnu"
CFLAGS="-march=pentium3 -O3 -pipe"
CXXFLAGS="-march=pentium3 -O3 -pipe"
ACCEPT_KEYWORDS="x86 ~x86"
MAKEOPTS="-j2"
AUTOCLEAN="yes"
SYNC="rsync://rsync.gentoo.org/gentoo-portage"
FEATURES="sandbox ccache"

[Comment 1 SpanKY 2003-03-01 12:35:43 UTC]

donny: think it's worth patching 2.2.7 ?

[Comment 2 Donny Davies (RETIRED) 2003-03-01 13:07:32 UTC]

hey mike,

if the poster tries _pre2 it should not be a problem anymore
since i removed smbwrapper/smbsh, they're basically broken
anyways because of some wacky glibc userspace thing.

yeah i might remove it from 2.2.7a but not sure, since
2.2.8 really looks like its coming down the pipe soon.

please try samba-2.2.8_pre2

_pre1 has been removed.

[Comment 3 Donny Davies (RETIRED) 2003-03-01 18:42:35 UTC]

please try _pre2

[Comment 4 Maurice van der Pot (RETIRED) 2003-03-02 10:06:04 UTC]

Tried _pre2 and it compiles ok. Thanx.