Bug 166050 – Fix for amarok's lyrc script brokeness (stray ")

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Jan Spitalnik 2007-02-09 10:48:48 UTC]

Hi,

In latest amarok-1.4.5, lyrc.rb is broken as it fails to fetchs over proxy due to a stray double-quote in the script on line 115. Fix attached.

Cheers,
        spity

Reproducible: Always

Steps to Reproduce:
1.Run amarok behind proxy
2.Select Lyrics tab
3.Boom :-)

Actual Results:  
sh: -c: line 0: unexpected EOF while looking for matching `"'
sh: -c: line 1: syntax error: unexpected end of file
/usr/lib/ruby/1.8/net/http.rb:560:in `initialize': No route to host - connect(2) (Errno::EHOSTUNREACH)
	from /usr/lib/ruby/1.8/net/http.rb:560:in `open'
	from /usr/lib/ruby/1.8/net/http.rb:560:in `connect'
	from /usr/lib/ruby/1.8/timeout.rb:48:in `timeout'
	from /usr/lib/ruby/1.8/timeout.rb:76:in `timeout'
	from /usr/lib/ruby/1.8/net/http.rb:560:in `connect'
	from /usr/lib/ruby/1.8/net/http.rb:553:in `do_start'
	from /usr/lib/ruby/1.8/net/http.rb:542:in `start'
	from /usr/lib/ruby/1.8/net/http.rb:1032:in `request'
	from /usr/lib/ruby/1.8/net/http.rb:769:in `get'
	from /usr/share/apps/amarok/scripts/lyrics_lyrc/lyrics_lyrc.rb:124:in `fetchLyrics'
	from /usr/share/apps/amarok/scripts/lyrics_lyrc/lyrics_lyrc.rb:190
	from /usr/share/apps/amarok/scripts/lyrics_lyrc/lyrics_lyrc.rb:176:in `loop'
	from /usr/share/apps/amarok/scripts/lyrics_lyrc/lyrics_lyrc.rb:176


Expected Results:  
Lyrics? :-)

[Comment 1 Jan Spitalnik 2007-02-09 10:49:25 UTC]

Created attachment 109611 [details, diff]
Lyrc script patch

[Comment 2 Dan 2007-03-16 23:16:57 UTC]

Thank you. 

I just committed your fix upstream and it will be in amarok-1.4.6.

[Comment 3 David Grant 2007-03-18 22:18:51 UTC]

close as this is fixed in UPSTREAM. thanks jmbsvicetto

[Comment 4 Dan 2007-03-19 04:33:42 UTC]

It probably should still be applied to the amarok ebuild--1.4.6 is most likely a ways off (if it gets released at all) as all attention is currently on 2.0

[Comment 5 Diego Elio Pettenò (RETIRED) 2007-06-07 18:31:53 UTC]

Will be in 1.4.5-r2.

[Comment 6 Diego Elio Pettenò (RETIRED) 2007-06-08 19:52:58 UTC]

This is in both 1.4.5-r2 and 1.4.6_pre.