Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 165286 - x11-apps/xset-1.0.2 automagic dependancy on x11-libs/libXfontcache-1.0.4
Summary: x11-apps/xset-1.0.2 automagic dependancy on x11-libs/libXfontcache-1.0.4
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal
Assignee: Gentoo X packagers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-02-04 16:01 UTC by Gergan Penkov
Modified: 2007-05-02 08:26 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Gergan Penkov 2007-02-04 16:01:08 UTC
cleaning the cruft on my system I unmerged libXfontcache, but as a result revdep-rebuild has shown xset broken because of this.
xset's ebuild does not have explicit dependency on libXfontcache in the ebuild, but configure.ac shows:
PKG_CHECK_MODULES(SET_FONTCACHE, xfontcache,
        [SAVE_CPPFLAGS="$CPPFLAGS"
        CPPFLAGS="$CPPFLAGS $SET_FONTCACHE_CFLAGS $SET_X11_CFLAGS"
        AC_CHECK_HEADERS([X11/extensions/fontcache.h X11/extensions/fontcacheP.h],,,[#include <X11/Xlib.h>])
        CPPFLAGS="$SAVE_CPPFLAGS"],[echo "not found"])
looking in xset.c reveals that xset could control the fontcache if build with libXfontcache:
#ifdef FONTCACHE
    fprintf (stderr, "    To control font cache:\n");
    fprintf (stderr, "\t fc [hi-mark [low-mark [balance]]]\n");
    fprintf (stderr, "\t    both mark values spcecified in KB\n");
    fprintf (stderr, "\t    balance value spcecified in percent (10 - 90)\n");
    fprintf (stderr, "    Show font cache statistics:\n");
    fprintf (stderr, "\t fc s\n");
#endif

so one possible resolution is to add unconditional depend on libXfontcache or to make it an use-flag
Comment 1 Joshua Baergen (RETIRED) gentoo-dev 2007-02-04 17:47:36 UTC
Thanks for catching this!

I'll make the dependency unconditional, since it's a very small compile and it would make sense to have this control by default.

I need a couple of keywords added to x11-libs/libXfontcache first - ~ia64 and ~x86-fbsd.
Comment 2 Joshua Baergen (RETIRED) gentoo-dev 2007-02-04 17:48:40 UTC
Oops - re-opening.
Comment 3 Raúl Porcel (RETIRED) gentoo-dev 2007-03-26 16:37:29 UTC
~ia64 done. Adding bsd to cc.
Comment 4 Peter Weller (RETIRED) gentoo-dev 2007-03-26 16:46:05 UTC
libXfontcache-1.0.4 keyworded ~x86-fbsd... and, unless I'm mistaken, bsd@gentoo.org is not on the CC list? armin76...?
Comment 5 Donnie Berkholz (RETIRED) gentoo-dev 2007-05-02 08:26:46 UTC
Fixed, thanks and sorry for the delay!