Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 164933 - dev-libs/crypto++-5.4 ebuild is forcing -msse2 on Athlon XP
Summary: dev-libs/crypto++-5.4 ebuild is forcing -msse2 on Athlon XP
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Library (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Crypto team [DISABLED]
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-02-01 23:21 UTC by Wojciech Milkowski
Modified: 2007-02-03 10:08 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
patch for GNUmakefile (crypto++-5.4-no-sse2.diff,574 bytes, patch)
2007-02-01 23:22 UTC, Wojciech Milkowski
Details | Diff
crypto++-5.4.ebuild patch (crypto++-5.4.ebuild.diff,340 bytes, patch)
2007-02-01 23:25 UTC, Wojciech Milkowski
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Wojciech Milkowski 2007-02-01 23:21:41 UTC
attached patch to GNUmakefile and ebuild resolves problem

Reproducible: Always

Steps to Reproduce:
Comment 1 Wojciech Milkowski 2007-02-01 23:22:53 UTC
Created attachment 108897 [details, diff]
patch for GNUmakefile
Comment 2 Wojciech Milkowski 2007-02-01 23:25:49 UTC
Created attachment 108899 [details, diff]
crypto++-5.4.ebuild patch
Comment 3 Jakub Moc (RETIRED) gentoo-dev 2007-02-02 09:08:44 UTC
I don't see what are you fixing here?

The SSE2 code can (and should) be disabled as needed at runtime by applications that are using crypto++, not made unavailable in the library itself... This is a feature and not a bug.
Comment 4 Wojciech Milkowski 2007-02-02 19:58:04 UTC
So why is there a phrase in ebuild:

        if use x86 || use amd64
        then
                append-flags -mno-sse2
        fi

that has no effect?
Comment 5 Jakub Moc (RETIRED) gentoo-dev 2007-02-02 22:52:38 UTC
(In reply to comment #4)
> So why is there a phrase in ebuild:

Because of an outdated gcc bug (see Bug 63922); it should be dropped as it compiles just fine w/ gcc-4.1 which is stable both on x86 and amd64. And yeah, it has absolutely no effect anyway:

<snip>
g++ -g -msse2 -pipe -c 3way.cpp
g++ -g -msse2 -pipe -c adler32.cpp
g++ -g -msse2 -pipe -c algebra.cpp
g++ -g -msse2 -pipe -c algparam.cpp
g++ -g -msse2 -pipe -c arc4.cpp
...
</snip>

This won't crosscompile (calls g++ directly) and ignores any C[XX]FLAGS, should be fixed.
Comment 6 Alon Bar-Lev (RETIRED) gentoo-dev 2007-02-03 10:07:50 UTC
Thanks!
Fixed, and added sse2 USE flag.
Comment 7 Alon Bar-Lev (RETIRED) gentoo-dev 2007-02-03 10:08:09 UTC
Oops.