Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 164479 - [PATCH] media-sound/amarok - Optional DAAP support
Summary: [PATCH] media-sound/amarok - Optional DAAP support
Status: RESOLVED UPSTREAM
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Diego Elio Pettenò (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-01-29 22:26 UTC by Bram Schoenmakers
Modified: 2007-02-01 18:58 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
amarok-1.4.4-r5 ebuild with optional DAAP support (amarok-1.4.4-r5.ebuild,2.64 KB, text/plain)
2007-01-29 22:27 UTC, Bram Schoenmakers
Details
Amarok patch to make DAAP optional (amarok-1.4.4+daap_optional.patch,1.74 KB, patch)
2007-01-29 22:28 UTC, Bram Schoenmakers
Details | Diff
Ebuild patch for optional DAAP support (amarok_daap_optional.patch,1.01 KB, patch)
2007-01-29 22:29 UTC, Bram Schoenmakers
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Bram Schoenmakers 2007-01-29 22:26:44 UTC
I know, I've read Diego's blog entry that the extra dependencies for Amarok 1.4.4-r4 aren't hurting the system that much. But still, I couldn't resist.

Attached some patches in order to make DAAP support optional in Amarok.
Comment 1 Bram Schoenmakers 2007-01-29 22:27:53 UTC
Created attachment 108543 [details]
amarok-1.4.4-r5 ebuild with optional DAAP support

Full ebuild for optional DAAP support. Patch based on -r4 will follow.
Comment 2 Bram Schoenmakers 2007-01-29 22:28:50 UTC
Created attachment 108545 [details, diff]
Amarok patch to make DAAP optional

Patches the Amarok build files in order to make DAAP support optional.
Comment 3 Bram Schoenmakers 2007-01-29 22:29:51 UTC
Created attachment 108547 [details, diff]
Ebuild patch for optional DAAP support

This patch is based on the amarok-1.4.4-r4 ebuild.
Comment 4 Diego Elio Pettenò (RETIRED) gentoo-dev 2007-01-29 22:39:41 UTC
Ian Monroe (eean) does not want this to be tied to an useflag, or at least so he said yesterday.
He's looking into it to see if it makes sense to just disable it entirely, but up to then, there won't be any daap useflag with optional support.
Comment 5 Bram Schoenmakers 2007-01-29 22:41:44 UTC
By the way, I posted the non-ebuild related patch to KDE Bugzilla.
Comment 6 Bram Schoenmakers 2007-02-01 17:48:23 UTC
Diego, as you may have seen, the patch has been applied to Amarok. What should the status of this bug report be then? Reopen it?
Comment 7 Diego Elio Pettenò (RETIRED) gentoo-dev 2007-02-01 18:57:29 UTC
I'm not sure, 1.4.5 packager pre-release should be today, I'm not sure if it's _that urgent_ not to wait a couple of days.
Comment 8 Bram Schoenmakers 2007-02-01 18:58:39 UTC
OK, I was not aware of the time schedule.