Bug 164007 – want__thread() check in glibc-2.5 ebuild is broken

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Andrew Gaffney (RETIRED) 2007-01-27 00:21:36 UTC]

I've only looked at the glibc-2.5 ebuild, but the others may be broken in the same way. In check_nptl_support(), want__thread is called like so:

        if ! eend $(want__thread); then

This doesn't seem to work, as it passes the check on hppa with gcc-4.1.1-r3, when the check really fails. If I change it to the following, then it works properly:

        want__thread
        if ! eend $?; then

[Comment 1 Andrew Gaffney (RETIRED) 2007-01-27 00:28:02 UTC]

Also, I only found this because I removed the explicit 'return 1' in want_tls() for hppa to attempt to build glibc-2.5 with nptl.

[Comment 2 SpanKY 2007-01-27 01:46:32 UTC]

the point was to merge the steps, not break them apart again

i think we actually want:
if ! eend $(want__thread; echo $?); then

[Comment 3 Andrew Gaffney (RETIRED) 2007-01-27 01:55:04 UTC]

Sure, that would work as well. It doesn't really matter as long as the code actually does what it was originally intended to do ;)

[Comment 4 Andrew Gaffney (RETIRED) 2007-01-27 02:01:25 UTC]

Not that there was any doubt, but that variation fails properly.

[Comment 5 SpanKY 2007-01-27 02:20:17 UTC]

fixed in cvs, cheers