163959 – media-video/totem-2.16.4: pass plugindir in make install, don't sed Makefile.in

Bug 163959 - media-video/totem-2.16.4: pass plugindir in make install, don't sed Makefile.in

Summary: media-video/totem-2.16.4: pass plugindir in make install, don't sed Makefile.in

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	New packages (show other bugs)
Hardware:	All Linux

Importance:	High trivial (vote)
Assignee:	Gentoo Linux Gnome Desktop Team

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2007-01-26 19:02 UTC by Ed Catmur
Modified:	2007-10-01 18:05 UTC (History)
CC List:	1 user (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Ed Catmur 2007-01-26 19:02:24 UTC

totem-2.16.4.ebuild has in src_unpack:

    # Fix hardcoded plugindir
    sed -i -e \
        's|mozilla|nsbrowser|' \
        ${S}/browser-plugin/Makefile.am \
        ${S}/browser-plugin/idl/Makefile.am

However, this is an overridable Makefile variable, so should be set at usage time:

src_install() {
    gnome2_src_install plugindir=/usr/$(get_libdir)/nsbrowser/plugins
}

Comment 1 Jakub Moc (RETIRED) gentoo-dev

2007-10-01 18:05:18 UTC

Fixed in 2.18.x