I created a patch with update enhancements to the xfce44.eclass. This include updating of gtk icon cache, mime and desktop databases, thing needed by many xfce packages. Updates are performed only when needed during install and uninstall phase. There is possibility to force updates of certain things using defined XFCE_UPDATES variable. Additionally i moved all global definitions of variables to header of a eclass to increase readability. I tested this eclass on few live ebuilds, all internal update thing were also tested deeply during personal usage of my xfce ebuilds.
Created attachment 108096 [details, diff] xfce44.eclass.diff diff for xfce44.eclass
eek, copy and paste from gnome2-utils.eclass and fdo-mime.eclass.. we should inherit fdo-mime gnome2-utils in eclass instead and add few functions using them instead of this duplication.
Created attachment 108139 [details] xfce44.eclass.diff Keeping it simple but yet as functional.
Done
Thanks welp.
drak, at least read what i did. Thanks for for Your comments and this obsolete marking of others work, i've learned much about You. See You guys. PS. LOL, that's a official xfce member.
(In reply to comment #6) > drak, at least read what i did. > Thanks for for Your comments and this obsolete marking of others work, i've > learned much about You. > > See You guys. > > PS. LOL, that's a official xfce member. > I did, found out duplication of work someone else has allready done. Looked into gnome2.eclass and how they implent it, nice and simple. Conditionalizing fdo-mime functions is waste of time since it takes almost no time at all. And by now you know gnome2-utils allready checks if icons cache update is necessary or not. And no, I am not official anything. Stop insulting people. Your report is appericiated afterall, be glad that it's fixed.
> I did, found out duplication of work someone else has allready done. Looked > into gnome2.eclass and how they implent it, nice and simple. Conditionalizing > fdo-mime functions is waste of time since it takes almost no time at all. And > by now you know gnome2-utils allready checks if icons cache update is necessary or > not. > So You know that after uninstall icon cache is not updated, even if it suppose to be updated. > And no, I am not official anything. Stop insulting people. Your report is > appericiated afterall, be glad that it's fixed. > So why did You close this bug and obsolete my work? This is not insulting, this is about who is responsible for what.
If such an operation is desirable it could be simple as.. In beginning.. FDO_MIME_UPDATE=${FDO_MIME_UPDATE:="1"} xfce44_pkg_postinst() { if [[ "${FDO_MIME_UPDATE}" = "1" ]]; then fdo-mime_desktop_database_update fdo-mime_mime_database_update fi gnome2_icon_cache_update } And same for postrm.. Now, if you set FDO_MIME_UPDATE="0" in beginning of xfce4-dev-tools-4.4.0.ebuild, it wouldn't run these functions. But as said.. Gnome folks didn't bother, why should we?
> > So You know that after uninstall icon cache is not updated, even if it suppose > to be updated. You are wrong again, see.. -- cut -- unique hicolor # emerge -C xfce4-mount xfce-extra/xfce4-mount selected: 0.4.8 protected: none omitted: none >>> 'Selected' packages are slated for removal. >>> 'Protected' and 'omitted' packages will not be removed. >>> Waiting 5 seconds before starting... >>> (Control-C to abort)... >>> Unmerging in: 5 4 3 2 1 >>> Unmerging xfce-extra/xfce4-mount-0.4.8... No package files given... Grabbing a set. <<< obj /usr/share/icons/hicolor/scalable/apps/xfce-mount.svg <<< obj /usr/share/icons/hicolor/48x48/apps/xfce-mount.png --- !empty dir /usr/share/icons/hicolor/scalable/apps --- !empty dir /usr/share/icons/hicolor/scalable --- !empty dir /usr/share/icons/hicolor/48x48/apps --- !empty dir /usr/share/icons/hicolor/48x48 --- !empty dir /usr/share/icons/hicolor --- !empty dir /usr/share/icons * Updating desktop mime database ... * Updating shared mime info database ... *** * Updating MIME database in //usr/share/mime... Wrote 504 strings at 20 - 2a08 Wrote aliases at 2a08 - 2bfc Wrote parents at 2bfc - 3608 Wrote literal globs at 3608 - 3664 Wrote suffix globs at 3664 - 6b9c Wrote full globs at 6b9c - 6bc0 Wrote magic at 6bc0 - c9ac Wrote namespace list at c9ac - c9bc *** * Updating icons cache ... [ ok ] * GNU info directory index is up-to-date. -- cut -- It gets executed when it has actually something to do, as said.. gnome2-utils has a check.
(In reply to comment #10) > > > > So You know that after uninstall icon cache is not updated, even if it suppose to be updated. > > > > You are wrong > Did You try other package managers? > again, see.. > Again? So first time was when? For me it really doesn't matter what would be used at the end, it is just how it is done. Changes in eclasses are important, they shouldn't be done so lightly as it is done now. As for conditionals, You did propose sth now, but here changes are already commited, not too late for discussion?
