Dbus is no longer needed to compile xfdesktop. This dependecy should be conditional (a "dbus" USE flag). Reproducible: Always
Because it's not optional, read the code.
An attempt on making this not automagic attached...
Created attachment 107956 [details, diff] xfdesktop-4.4.0.ebuild.diff
(In reply to comment #3) > Created an attachment (id=107956) [edit] > xfdesktop-4.4.0.ebuild.diff Works, but I realized that both thunar and dbus are needed to enable desktop file icons, otherwise thunar is not used. So it seems to me that there should be only one flag (eg. thunar-vfs) instead of dbus and thunar-vfs. BTW --disable-thunar-vfs option is ignored by configure (that must have changed in the latest release).
(In reply to comment #4) > Works, but I realized that both thunar and dbus are needed to enable desktop > file icons, otherwise thunar is not used. So it seems to me that there should > be only one flag (eg. thunar-vfs) instead of dbus and thunar-vfs. > BTW --disable-thunar-vfs option is ignored by configure (that must have changed > in the latest release). Erm, no; those are two completely separate features...
(In reply to comment #4) > (In reply to comment #3) > > Created an attachment (id=107956) [edit] > > xfdesktop-4.4.0.ebuild.diff > Works, but I realized that both thunar and dbus are needed to enable desktop > file icons, otherwise thunar is not used. So it seems to me that there should > be only one flag (eg. thunar-vfs) instead of dbus and thunar-vfs. > BTW --disable-thunar-vfs option is ignored by configure (that must have changed > in the latest release). > The trouble with this is on a system where the administrator explicitly doesn't want dbus support (for whatever reason) setting the thunar-vfs useflag would make xfdesktop depend on dbus - even though "-dbus" is in make.conf. It's a pity portage can't set other useflags from one flag... i.e. have a "desktop-icons" flag and if this is on also turn the "dbus" and "thunar-vfs" on, otherwise allow them to be set individually.
(In reply to comment #6) > The trouble with this is on a system where the administrator explicitly doesn't > want dbus support (for whatever reason) setting the thunar-vfs useflag would > make xfdesktop depend on dbus How would it make it depend on dbus? That's exactly what the patch aims to fix.
There is no --enable-dbus/--disable-dbus in xfdesktop, but some of the other USE flags need it. Are you saying you can have minimized applications on xfdesktop without dbus? If so, it can be fixed.
(In reply to comment #8) > There is no --enable-dbus/--disable-dbus in xfdesktop, but some of the other > USE flags need it. > > Are you saying you can have minimized applications on xfdesktop without dbus? > If so, it can be fixed. > No, I was just answering comment #4. The patch fixes it. Does using thunar-vfs actually do anything in xfdesktop if dbus isn't on the system?
(In reply to comment #9) > (In reply to comment #8) > > There is no --enable-dbus/--disable-dbus in xfdesktop, but some of the other > > USE flags need it. > > > > Are you saying you can have minimized applications on xfdesktop without dbus? > > If so, it can be fixed. > > > No, I was just answering comment #4. The patch fixes it. > > Does using thunar-vfs actually do anything in xfdesktop if dbus isn't on the > system? > Not that I'm aware of, far as I know --enable-file-icons needs --enable-thunarx, and depends on dbus-glib. Then there is --enable-exo which adds effects to icons. So I'd say these 3 flags, including dbus-glib dep should be under one single USE flag since they don't do anything by themselfs at least yet..
I'm really not going to dig into this over and over again; current dbus dependency is completely wrong, someone fix it one way or the other using the above patch or something else. (Plus leaving it non-optional will plain piss off lots of people.)
You get dbus if USE="thunar-vfs" is enabled now, because it's needed. Period. If you want Xfce4 without dbus.. USE="-dbus", of course. USE="-thunar-vfs" for xfdesktop and beware of bad plugins directly depending on dbus..
