Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 163355 - media-video/vlc doesn't support ivtv (PVR-?50) input
Summary: media-video/vlc doesn't support ivtv (PVR-?50) input
Status: RESOLVED INVALID
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High enhancement
Assignee: Gentoo Media-video project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-01-22 22:33 UTC by bware
Modified: 2007-02-23 21:05 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
ebuils using ivtv USE flag (vlc-0.8.6-r1.ebuild,7.94 KB, text/plain)
2007-01-22 22:35 UTC, bware
Details
ebuild diff (vlc-0.8.6-r2.diff,1.06 KB, patch)
2007-01-23 10:45 UTC, bware
Details | Diff
ebuild patch for vlc-0.8.6 (vlc-0.8.6_p18636-pvr-ebuild.patch,1.51 KB, patch)
2007-02-04 13:48 UTC, Sander Sweers
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description bware 2007-01-22 22:33:16 UTC
The VLC 'configure' has an option '--enable-pvr' to add support for playback and streaming from Hauppauge PVR cards.

As we already have an ivtv USE flag it seems a pitty not to use it.
Comment 1 bware 2007-01-22 22:35:50 UTC
Created attachment 107850 [details]
ebuils using ivtv USE flag

Only tested on AMD64 with PVR-350 and ivtv-0.9.1, but I expect it works generally.
Comment 2 Diego Elio Pettenò (RETIRED) gentoo-dev 2007-01-22 23:32:38 UTC
Submit unified diffs _not_ new ebuilds.
Comment 3 bware 2007-01-23 10:45:20 UTC
Created attachment 107887 [details, diff]
ebuild diff

Sorry, here is the diff.

My morning coffee also tells me I should have probably have added ivtv to RDEPEND!
Comment 4 Sander Sweers 2007-02-04 13:48:04 UTC
Created attachment 109120 [details, diff]
ebuild patch for vlc-0.8.6

It is not that simple. The dvb flag also sets the pvr flag but I am not sure why? Attached is my attempt which probably can be done simpler but I do not know how. 

There us also a bug in enabling live support where it overwrites $myconf instead of appending.
Comment 5 Alexis Ballier gentoo-dev 2007-02-23 17:52:23 UTC
Thanks Sander for pointing that the workaround for live overwrites myconf, it's fixed now.


I don't understand why you want to add all those lines to the ebuild : 
why not adding a ivtv useflag that would depend on ivtv and just use $(use_enable ivtv pvr) ? 
I suppose that ivtv cannot work without dvb, but imho it's safe to assume that a user that wants to support a special dvb card wants also to support dvb ;)
Comment 6 Sander Sweers 2007-02-23 19:54:11 UTC
(In reply to comment #5)
> I don't understand why you want to add all those lines to the ebuild : 
> why not adding a ivtv useflag that would depend on ivtv and just use
> $(use_enable ivtv pvr) ?

Hmm looking back now I do not know anymore why I did this.... Maybe because dvb also enables pvr support, but why. Anyway, the first patch + RDEPEND on ivtv looks way better then my attempt now so please ignore it ;-)
Comment 7 Alexis Ballier gentoo-dev 2007-02-23 21:05:14 UTC
so, pvr is already enabled when dvb useflag is set and we cannot depend on ivtv since vlc has much more keywords than ivtv; we get bad dependencies by doing that (even if this can be sorted out, this seems pointless to me to depend on a kernel driver).

closing as invalid as you just need to enable dvb to get support for hauppage pvr.

Feel free to reopen or ask for this to be reopenned if I misunderstood something there.