Bug 163246 – ~xfce-extra/xfce4-genmon-3.0 - missing dev-util/intltool DEPEND

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Jakub Moc (RETIRED) 2007-01-22 13:49:44 UTC]

Calling intltoolize there, but missing dev-util/intltool in DEPEND. ;)



--- xfce4-genmon-3.0-r1.ebuild	2007-01-21 18:59:04.000000000 +0100
+++ xfce4-genmon-3.0-r1.ebuild	2007-01-22 14:49:04.000000000 +0100
@@ -12,13 +12,14 @@
 DESCRIPTION="Xfce4 panel generic monitor plugin"
 KEYWORDS="~alpha ~amd64 ~hppa ~ia64 ~mips ~ppc ~ppc64 ~sparc ~x86"
 
-DEPEND="xfce-extra/xfce4-dev-tools"
+RDEPEND="xfce-extra/xfce4-dev-tools"
+DEPEND="${RDEPEND}
+	dev-util/intltool"
 
 src_unpack() {
 	unpack ${A}
-	cd ${S}
-	epatch ${FILESDIR}/${P}-asneeded.patch
+	cd "${S}"
+	epatch "${FILESDIR}"/${P}-asneeded.patch
 	AT_M4DIR=/usr/share/xfce4/dev-tools/m4macros eautoreconf
 	intltoolize --automake --copy --force || die "intltoolize failed"
 }
-

[Comment 1 Samuli Suominen (RETIRED) 2007-01-22 17:28:07 UTC]

(In reply to comment #0)
> Calling intltoolize there, but missing dev-util/intltool in DEPEND. ;)
> -DEPEND="xfce-extra/xfce4-dev-tools"
> +RDEPEND="xfce-extra/xfce4-dev-tools"
> +DEPEND="${RDEPEND}
> +       dev-util/intltool"

That is wrong. Right way is more like..

RDEPEND=">=xfce-base/xfce4-panel-4.3.99"
DEPEND="${RDEPEND}
>=xfce-extra/xfce4-dev-tools-4.3.99
dev-util/intltool"

Because dev-tools is definately NOT a RDEPEND, it's only set of macros used by eautoreconf.

[Comment 2 Samuli Suominen (RETIRED) 2007-01-23 22:06:47 UTC]

Fixed, thanks to welp.