Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 162851 - sys-fs/cryptsetup-luks should install /sbin/cryptsetup setup at least as a symlink
Summary: sys-fs/cryptsetup-luks should install /sbin/cryptsetup setup at least as a sy...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal
Assignee: Benjamin Smee (strerror) (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-01-19 22:15 UTC by Petteri Räty (RETIRED)
Modified: 2007-01-26 15:37 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Petteri Räty (RETIRED) gentoo-dev 2007-01-19 22:15:22 UTC
betelgeuse@pena ~ $ qlist hal | xargs grep cryptsetup
/usr/share/hal/scripts/hal-luks-remove:CRYPTSETUP=/sbin/cryptsetup
/usr/share/hal/scripts/hal-luks-setup:CRYPTSETUP=/sbin/cryptsetup
/usr/share/hal/scripts/hal-luks-teardown:CRYPTSETUP=/sbin/cryptsetup

Every other distribution installs /sbin so we should at least provide a symlink /sbin/crypsetup --> /bin/crypsetup or the other way around. Hal should probably also fix to not hardcode stuff like this but it is not the only one I have come across that had this problem (for example pmount had this before I fixed it there).

	econf \
		--sbindir=/bin \
		$(use_enable !dynamic static) \
		--libdir=/usr/$(get_libdir) \
		$(use_enable nls) \
		$(use_enable selinux) \
		|| die

Here we see that it is meant by upstream to go into /sbin.
Comment 1 SpanKY gentoo-dev 2007-01-19 23:14:30 UTC
i'd rather fix sys-fs/cryptsetup-luks to install into /sbin like everyone else

was there a specific reason for this Benjamin ?
Comment 2 Benjamin Smee (strerror) (RETIRED) gentoo-dev 2007-01-21 12:25:49 UTC
Yeah there was 2 issues. One upstream puts it in /usr and the second, more relevant issue was that embedded and co started to scream at me when I suggested that I put it, and the libs it relies on, in /sbin, /lib etc. See bug #112597 for a discussion about the lib placement for example.

The current situation is not optimal really, for example in my own usage I build it statically and then cp the bin to /sbin for using my scripts as my /usr is encrypted. That said, the reason I did that was the amount of resistance I got from people for adding more things to the / partition.

In reality if people are hardcoding this it's that which should be fixed imo, though I'm not against putting it in /sbin and /lib either but there are quite a few deps if we're going to build it in such a way that a dynamic binary will work in /sbin.
Comment 3 Petteri Räty (RETIRED) gentoo-dev 2007-01-21 13:09:29 UTC
Benjamin: There shouldn't be any objections to symlinking then?
Comment 4 Benjamin Smee (strerror) (RETIRED) gentoo-dev 2007-01-21 14:01:21 UTC
There are a few reasons why you might not want to symlink, but nothing to major I can think of off the top of my head.
Comment 5 SpanKY gentoo-dev 2007-01-21 18:08:10 UTC
Benjamin: i meant why is it /bin/cryptsetup and not /sbin/cryptsetup
Comment 6 Benjamin Smee (strerror) (RETIRED) gentoo-dev 2007-01-21 18:33:00 UTC
err cough, i forgot i'd change the sbindir. I had a reason at the time but I can't remember it now. No, I see no reason not to change the sbindir in econf.
Comment 7 Petteri Räty (RETIRED) gentoo-dev 2007-01-25 17:47:29 UTC
Just as a note that currently the pmount ebuild hardcodes /bin/cryptsetup so unless a symlink is done, that should be changed too. Well any way removing the hardcode makes sense any way.
Comment 8 SpanKY gentoo-dev 2007-01-26 07:44:39 UTC
i'd say fix pmount and leave out the symlink in /bin
Comment 9 Doug Goldstein (RETIRED) gentoo-dev 2007-01-26 14:05:28 UTC
And that's wrong Mike. Everything expects it in /sbin. We're overriding upstream's placement. Other scripts and programs expect it in /sbin. It's not just pmount.
Comment 10 Benjamin Smee (strerror) (RETIRED) gentoo-dev 2007-01-26 15:05:52 UTC
Just to be clear upstream place it in /usr/sbin.

I've modified the ebuild to put it in /sbin and symlink to /bin. Please start fixing the hardpaths as I won't leave the symlink in for that long....

Comment 11 SpanKY gentoo-dev 2007-01-26 15:37:34 UTC
wtf are you talking about Doug ... ive been saying it needs to be in /sbin and not /bin