Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 162843 - games-rpg/nwn-1.68-r1 : make_desktop_entry broken (with fix)
Summary: games-rpg/nwn-1.68-r1 : make_desktop_entry broken (with fix)
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Games (show other bugs)
Hardware: All Linux
: High minor (vote)
Assignee: Gentoo Games
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-01-19 19:56 UTC by Denis Dupeyron (RETIRED)
Modified: 2007-01-31 22:20 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---

Attachments
nwn-1.68-r1.ebuild.patch (nwn-1.68-r1.ebuild.patch,545 bytes, patch)
2007-01-19 19:58 UTC, Denis Dupeyron (RETIRED) 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Denis Dupeyron (RETIRED) gentoo-dev 2007-01-19 19:56:32 UTC 
A malicious line-break in the DESCRIPTION line breaks the make_desktop_entry statement in src_install(). Plus, capitalizing the first letter of ${DESCRIPTION} enables the generation of a comment that's consistent with others in menus (i.e. they seem to all start with a capital letter). Patch below.

Denis.
Comment 1 Denis Dupeyron (RETIRED) gentoo-dev 2007-01-19 19:58:02 UTC 
Created attachment 107476 [details, diff]
nwn-1.68-r1.ebuild.patch

The patch for the above breakage.
Comment 2 Chris Gianelloni (RETIRED) gentoo-dev 2007-01-31 22:20:52 UTC 
The funny thing is that this has been bugging me for a little while, now.  I didn't notice it right away, but I've been looking into it.  Thanks for spotting this one, it would have taken me damn near forever!