Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 162833 - app-emulation/xen-tools: patch to shutdown domains in parallel
Summary: app-emulation/xen-tools: patch to shutdown domains in parallel
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High trivial (vote)
Assignee: Gentoo Xen Devs
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-01-19 18:40 UTC by Jan Kundrát (RETIRED)
Modified: 2008-09-01 00:46 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
xendomains-parallel-shutdown.patch (xendomains-parallel-shutdown.patch,577 bytes, patch)
2007-01-19 18:41 UTC, Jan Kundrát (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Kundrát (RETIRED) gentoo-dev 2007-01-19 18:40:06 UTC
The xendomains init script is unnecesarilly waiting for each domain to exit before asking the next one to begin its shutdown. The attached patch asks all domains to stop and then waits for all of them, thus speeding the whole thing. Example output (which might be a bit confusing as the already-stopped domain is reported as "non-running" in the second pass):

joel ~ # /etc/init.d/xendomains stop
 * Shutting down Xen domains from /etc/xen/auto
 *   Asking domain box1-openldap to shutdown... ...                                                                                                   [ ok ]
 *   Asking domain box2-fds to shutdown... ...                                                                                                        [ ok ]
 *   Stopping domain box1-openldap ...                                                                                                                [ ok ]
 *   Not stopping domain box2-fds - not running
 * Closing screen session xen ...

Feel free to adjust those descriptions...
Comment 1 Jan Kundrát (RETIRED) gentoo-dev 2007-01-19 18:41:37 UTC
Created attachment 107473 [details, diff]
xendomains-parallel-shutdown.patch
Comment 2 Jan Kundrát (RETIRED) gentoo-dev 2008-04-05 02:43:00 UTC
Dear Xen maintainers, can we pleae get this fixed/applied?
Comment 3 Robert Buchholz (RETIRED) gentoo-dev 2008-09-01 00:46:58 UTC
Thank you for your bug report. I hope it is fixed with the following commit. Please let me know if it works, or not.

On a side node, I made parallel shutdown optional, but enabled by default. So users relying on this to avoid race conditions can disable it.

*xen-tools-3.3.0 (01 Sep 2008)

  01 Sep 2008; Robert Buchholz <rbu@gentoo.org>
  +files/xen-tools-3.3.0--as-needed.patch,
  +files/xen-tools-3.3.0-nostrip.patch,
  +files/xen-tools-3.3.0-xen-detect-nopie-fix.patch, files/xendomains.confd,
  files/xendomains.initd, metadata.xml, -xen-tools-3.2.0.ebuild,
  +xen-tools-3.3.0.ebuild:
  Version bump to Xen 3.3 (bug #201792). Fixes bugs:
   * Add USE flags for ACM and FLASK Xen Security Modules
   * Properly compile and uninstall python bytecode
   * RDEPEND on pyxml (bug #201255)
   * Remove libvncserver dependency
   * Shutdown xendomains in reverse start order (bug #210445)
   * Allow for parallel shutdown of xendomains (bug #162833)
   * Check that python is built with threading (bug #236092)