Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 162830 - stabilize x11-drivers/xf86-video-savage-2.1.2
Summary: stabilize x11-drivers/xf86-video-savage-2.1.2
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: x86 Linux
: High enhancement (vote)
Assignee: Gentoo X packagers
URL:
Whiteboard:
Keywords: Inclusion
Depends on:
Blocks:
 
Reported: 2007-01-19 17:40 UTC by Pablo De Nápoli
Modified: 2009-08-20 09:54 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
modified ebuild for the driver with the suggested patch (xf86-video-savage-2.1.2.ebuild,1.12 KB, text/plain)
2007-02-18 00:43 UTC, Pablo De Nápoli
Details
patch for fixing a crash from freedesktop.org (see comment #2) (savage-fix-crash.patch,633 bytes, patch)
2007-02-18 00:44 UTC, Pablo De Nápoli
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pablo De Nápoli 2007-01-19 17:40:57 UTC
I was having a lot of problems with vtk, and the applications
using them (paraview ; and mayavi wich is not in portage)
All of them hang (even the simplest examples from vtk 
tutorial. Even the pre-compiled packages from kitware 
didn't work.
(I have test it on Knoppix and it worked on the same machine,
 ... what the hell was going on?)

I was investigating the problem during a week, until I had
the perhaps obvious idea (but it took me a whoie 
week to realize!) update the savage driver!
Then everything works as expected.

So, please update the stable savage driver to
x11-driver/xf86-video-savage-2.1.2
(since 2.1.1 is plainly buggy)

My card identifies itself as

01:00.0 VGA compatible controller: S3 Inc. ProSavage KM133 (rev 03)

(using lspci)

I'm using sci-libs/vtk-5.0.2 and sci-visualization/paraview-2.4.4

Reproducible: Always

Steps to Reproduce:
1.Run step 1 example from vtk tutorial or
paraview in a machine with a savage card
and using the version 2.1.1 of the driver
2. The X server hangs...
3.
Comment 1 Joshua Baergen (RETIRED) gentoo-dev 2007-01-27 20:30:16 UTC
Arch teams, this package has been in the tree for a few months and I don't know of any open bugs for it.  Like Pablo says, it fixes some problems that are in 2.1.1.  Please stabilize at your leisure.
Comment 2 Slava Gorbunov 2007-01-28 21:45:12 UTC
(In reply to comment #1)
> Arch teams, this package has been in the tree for a few months and I don't know
> of any open bugs for it.  Like Pablo says, it fixes some problems that are in
> 2.1.1.  Please stabilize at your leisure.

Note that this package requires drm modules from the git repository at freedesktop.org. It doesn't work with savage.ko from 2.6.19.2 kernel, but works with savage.ko and drm.ko from git.freedesktop.org. I've tested it with SuperSavage card integrated into IBM ThinkPad T23.

Also you probably should apply this patch (fix savage respawn crash):
http://gitweb.freedesktop.org/?p=xorg/driver/xf86-video-savage.git;a=commitdiff;h=3e2d370e291f5f222de88075f1f285446cca0569

This version of driver have some bugs which xf86-video-savage-2.0.2.3 didn't have (for example, Blender with current version of this driver completely distorts screen on startup, though with 2.0.2.3 it worked fine), but 2.0.2.3 is incompatible with new xorg-server.
Comment 3 Joshua Baergen (RETIRED) gentoo-dev 2007-01-28 22:12:32 UTC
(In reply to comment #2)
> Note that this package requires drm modules from the git repository at
> freedesktop.org. It doesn't work with savage.ko from 2.6.19.2 kernel, but works
> with savage.ko and drm.ko from git.freedesktop.org. I've tested it with
> SuperSavage card integrated into IBM ThinkPad T23.

Is that because of bugs in the kernel?
Comment 4 Slava Gorbunov 2007-01-28 23:18:42 UTC
(In reply to comment #3)
> Is that because of bugs in the kernel?
I suppose, no. Apparently, the module in vanilla kernel is outdated (it works well with older drivers, but not with more recent). I have used savage driver 2.0.2 with vanilla kernel's module without considerable problems (the only problem was concerned with hardware 3d after resuming from software suspend), but after upgrading to 2.1.2 all GL programs begin to report errors during initialization (something about failure while trying to map buffer, I didn't remember this exactly) and fall back to indirect rendering. Installing drm modules from freedesktop git repository have solved this problem (the modules in x11-drm package from portage are outdated, too).

Comment 5 Joshua Baergen (RETIRED) gentoo-dev 2007-01-30 03:11:00 UTC
Alright.

Sorry for the noise arch teams, sounds like this isn't quite ready yet.

Marking Inclusion for the suggested patch in comment #2.
Comment 6 Pablo De Nápoli 2007-02-18 00:41:58 UTC
I want to thank all of you for your help, and specially
Slava Gorbunov for comment  #2.

I'm sending to you an ebuild for x11-drivers/xf86-video-savage and a patch file, for applying the patch that you suggest.

I was experimenting a crash at the end of kde session
(using kde). I'm using kde 3.5.6 from portage.
(I wasn't sure about the cause: it didn't thought it was the video driver, it thought it was the new version of KDE, or perhaps something wrong-compiled
so that I was compiling again all the packages on which kdebase depends upon!) 
I've tried adding the patch that you suggested and the problem was fixed.

I suggest that you add this to portage.
Comment 7 Pablo De Nápoli 2007-02-18 00:43:08 UTC
Created attachment 110506 [details]
modified ebuild for the driver with the suggested patch
Comment 8 Pablo De Nápoli 2007-02-18 00:44:16 UTC
Created attachment 110507 [details, diff]
patch for fixing a crash from freedesktop.org (see comment #2)
Comment 9 Pablo De Nápoli 2007-02-18 00:51:00 UTC
One more observation: regardless of comment #2, I'm using this driver
now with (vanilla) kernel 2.6.20 and it seems to work fine.
Comment 10 Joshua Baergen (RETIRED) gentoo-dev 2007-02-18 19:39:47 UTC
Thanks for the files.  This bug is marked Inclusion, so it'll get into the tree once we have time.
Comment 11 Pablo De Nápoli 2007-02-19 14:05:42 UTC
I've checked that the Debian guys have already applied this patch to this package, which will be included in the "Etch" distribution (to be released soon)

http://packages.debian.org/changelogs/pool/main/x/xserver-xorg-video-savage/xserver-xorg-video-savage_2.1.2-3/changelog
Comment 12 Joshua Baergen (RETIRED) gentoo-dev 2007-02-19 21:16:55 UTC
Thanks guys, the patch is in the tree with 2.1.2-r1.  We'll stabilize 2.1.2-r1 after it gets some testing time.
Comment 13 Tomáš Chvátal (RETIRED) gentoo-dev 2009-08-20 09:54:09 UTC
bugzie
Comment 14 Tomáš Chvátal (RETIRED) gentoo-dev 2009-08-20 09:54:28 UTC
Cleaning old bugs with state LATER.

This one is fixed because of 2.2.1 is stable.