* QA Notice: Package has poor programming practices which may compile * fine but exhibit random runtime failures. * hotplug.c:285: warning: implicit declaration of function 'isdigit'
Don't care.
(In reply to comment #1) > Don't care. > Quoting QA die message: !!! poor code kills airplanes Fixing this bug requires just a line that includes the right header: man isdigit -> #include <ctype.h>
If any airplane uses or has HAL in any of it's on board systems then all the passengers, pilots, crew, airline personnel, and all associated ground crew deserve to die... Please refer to Comment #1, if that's not acceptable. Find upstream, file a bug with upstream, provide a patch, link this bug to upstream's bug, and get upstream to be responsive and not snub you. THEN... and ONLY then... will I care.
SapnKY: As we can see here some devs simply don't give a rats ass even when being presented with a patch.
so if they're going to be tools, we fix it for them the fix is pretty obvious; not taking care of it exhibits extreme laziness
The fix is clearly something that should be going upstream. Encouraging developers to start applying these kinds of patches just for Gentoo is highly irresponsible.
no one is encouraging that, shut yer pie hole
My point of view about this is here: https://bugs.gentoo.org/show_bug.cgi?id=162711#c3
You wanna talk about poor programming practices? Why don't you guys go after this code... Because THESE warnings have actually caused a problem.. HINT... it's KDE... NOT hal.. specifically krdc In file included from rfbproto.c:1181: tight.c: In function 'HandleTight8': tight.c:99: warning: unused variable 'rawData' tight.c:91: warning: unused variable 'gcv' tight.c: In function 'InitFilterCopy8': tight.c:308: warning: unused parameter 'rh' tight.c: In function 'FilterGradient8': tight.c:434: warning: suggest parentheses around + or - in operand of & tight.c:448: warning: suggest parentheses around + or - in operand of & tight.c: In function 'InitFilterPalette8': tight.c:462: warning: unused variable 'palette' tight.c:460: warning: unused variable 'i' tight.c:458: warning: unused parameter 'rh' In file included from rfbproto.c:1186: tight.c: In function 'HandleTight16': tight.c:99: warning: unused variable 'rawData' tight.c:91: warning: unused variable 'gcv' tight.c: In function 'InitFilterCopy16': tight.c:308: warning: unused parameter 'rh' tight.c: In function 'FilterGradient16': tight.c:434: warning: suggest parentheses around + or - in operand of & tight.c:448: warning: suggest parentheses around + or - in operand of & tight.c: In function 'InitFilterPalette16': tight.c:462: warning: unused variable 'palette' tight.c:460: warning: unused variable 'i' tight.c:458: warning: unused parameter 'rh' tight.c: In function 'DecompressJpegRect16': tight.c:576: warning: comparison between signed and unsigned tight.c:576: warning: comparison between signed and unsigned In file included from rfbproto.c:1191: tight.c: In function 'HandleTight32': tight.c:99: warning: unused variable 'rawData' tight.c:91: warning: unused variable 'gcv' tight.c: In function 'InitFilterCopy32': tight.c:308: warning: unused parameter 'rh' tight.c: In function 'FilterGradient32': tight.c:434: warning: suggest parentheses around + or - in operand of & tight.c:448: warning: suggest parentheses around + or - in operand of & tight.c: In function 'InitFilterPalette32': tight.c:458: warning: unused parameter 'rh' tight.c: In function 'DecompressJpegRect32': tight.c:576: warning: comparison between signed and unsigned tight.c:576: warning: comparison between signed and unsigned rfbproto.c: In function 'JpegInitSource': rfbproto.c:1284: warning: unused parameter 'cinfo' rfbproto.c: In function 'JpegFillInputBuffer': rfbproto.c:1290: warning: unused parameter 'cinfo' rfbproto.c: In function 'JpegSkipInputData': rfbproto.c:1302: warning: comparison between signed and unsigned rfbproto.c:1300: warning: unused parameter 'cinfo' rfbproto.c: In function 'JpegTermSource': rfbproto.c:1313: warning: unused parameter 'cinfo'
