Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 162431 - [QA] x11-base/xorg-server-1.1.1-r4 has poor programming practices
Summary: [QA] x11-base/xorg-server-1.1.1-r4 has poor programming practices
Status: RESOLVED UPSTREAM
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo X packagers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-01-16 21:39 UTC by Sandro Bonazzola (RETIRED)
Modified: 2007-09-30 20:01 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sandro Bonazzola (RETIRED) gentoo-dev 2007-01-16 21:39:40 UTC
* QA Notice: Package has poor programming practices which may compile
 *            fine but exhibit random runtime failures.
 * access.c:1399: warning: implicit declaration of function '_XSERVTransGetPeerAddr'
access.c:1471: warning: implicit declaration of function '_XSERVTransIsLocal'
access.c:1481: warning: implicit declaration of function '_XSERVTransGetConnectionNumber'
io.c:378: warning: implicit declaration of function '_XSERVTransRead'
io.c:977: warning: implicit declaration of function '_XSERVTransDisconnect'
io.c:978: warning: implicit declaration of function '_XSERVTransClose'
io.c:1129: warning: implicit declaration of function '_XSERVTransWritev'
utils.c:949: warning: implicit declaration of function '_XSERVTransNoListen'
xdmauth.c:281: warning: implicit declaration of function '_XSERVTransGetPeerAddr'
xdmauth.c:283: warning: implicit declaration of function '_XSERVTransConvertAddress'
../hw/xfree86/os-support/shared/libc_wrapper.c:264: warning: implicit declaration of function 'strlcat'
../hw/xfree86/os-support/shared/libc_wrapper.c:270: warning: implicit declaration of function 'strlcpy'
../hw/xfree86/os-support/shared/libc_wrapper.c:388: warning: implicit declaration of function 'vsscanf'
../hw/xfree86/os-support/shared/libc_wrapper.c:780: warning: implicit declaration of function 'vfscanf'
../cfb/cfbpixmap.c:170: warning: implicit declaration of function 'mfbGetendtab'
../cfb/cfbtegblt.c:195: warning: implicit declaration of function 'ldl_u'
../cfb/cfbpolypnt.c:140: warning: implicit declaration of function 'ffs'
../cfb/cfbpixmap.c:170: warning: implicit declaration of function 'mfbGetendtab'
../cfb/cfbfillsp.c:562: warning: implicit declaration of function 'ldl_u'
../cfb/cfbtegblt.c:195: warning: implicit declaration of function 'ldl_u'
../cfb/cfbpolypnt.c:140: warning: implicit declaration of function 'ffs'
../cfb/cfbcppl.c:393: warning: implicit declaration of function 'mfbGetpartmasks'
../cfb/cfbcppl.c:399: warning: implicit declaration of function 'mfbGetstarttab'
../cfb/cfbcppl.c:399: warning: implicit declaration of function 'mfbGetendtab'
../cfb/cfbpixmap.c:170: warning: implicit declaration of function 'mfbGetendtab'
../cfb/cfbfillsp.c:562: warning: implicit declaration of function 'ldl_u'
../cfb/cfbtegblt.c:195: warning: implicit declaration of function 'ldl_u'
../cfb/cfbpolypnt.c:140: warning: implicit declaration of function 'ffs'
../cfb/cfbcppl.c:393: warning: implicit declaration of function 'mfbGetpartmasks'
../cfb/cfbcppl.c:399: warning: implicit declaration of function 'mfbGetstarttab'
../cfb/cfbcppl.c:399: warning: implicit declaration of function 'mfbGetendtab'
xf86Events.c:1291: warning: implicit declaration of function 'backtrace'
xf86Events.c:1292: warning: implicit declaration of function 'backtrace_symbols'
./../shared/libc_wrapper.c:264: warning: implicit declaration of function 'strlcat'
./../shared/libc_wrapper.c:270: warning: implicit declaration of function 'strlcpy'
./../shared/libc_wrapper.c:388: warning: implicit declaration of function 'vsscanf'
./../shared/libc_wrapper.c:780: warning: implicit declaration of function 'vfscanf'
../../../../hw/xfree86/os-support/shared/libc_wrapper.c:264: warning: implicit declaration of function ‘strlcat’
../../../../hw/xfree86/os-support/shared/libc_wrapper.c:270: warning: implicit declaration of function ‘strlcpy’
../../../../hw/xfree86/os-support/shared/libc_wrapper.c:388: warning: implicit declaration of function ‘vsscanf’
../../../../hw/xfree86/os-support/shared/libc_wrapper.c:780: warning: implicit declaration of function ‘vfscanf’


 * QA Notice: Package has poor programming practices which may compile
 *            but will almost certainly crash on 64bit architectures.
 * Function `backtrace_symbols' implicitly converted to pointer at xf86Events.c:1292
Comment 1 Joshua Baergen (RETIRED) gentoo-dev 2007-02-11 18:07:54 UTC
It looks like the 64-bit problem is fixed in 1.2.0, but there are still quite a few warnings.
Comment 2 DEMAINE Benoît-Pierre, aka DoubleHP 2007-09-24 11:40:30 UTC
x11-base/xorg-server-1.1.1-r4 is not in portage anymore; please close this bug, or update if still exist.
=> CLOSE or TEST-REQUEST
Comment 3 Sandro Bonazzola 2007-09-24 18:57:44 UTC
As you wish. 
I can't update the Summary because I've retired but this is still an issue.

Updated with output of 1.4-r1:
 [33;01m*[0m QA Notice: Package has poor programming practices which may compile
 [33;01m*[0m            fine but exhibit random runtime failures.
 [33;01m*[0m fbpict.c:400: warning: implicit declaration of function 'pixman_image_set_source_clipping'

fbpict.c:400: warning: implicit declaration of function 'pixman_image_set_source_clipping'

../hw/xfree86/os-support/shared/libc_wrapper.c:253: warning: implicit declaration of function 'strlcat'

../hw/xfree86/os-support/shared/libc_wrapper.c:259: warning: implicit declaration of function 'strlcpy'

../hw/xfree86/os-support/shared/libc_wrapper.c:377: warning: implicit declaration of function 'vsscanf'

../hw/xfree86/os-support/shared/libc_wrapper.c:769: warning: implicit declaration of function 'vfscanf'

../cfb/cfbpixmap.c:164: warning: implicit declaration of function 'mfbGetendtab'

../cfb/cfbpixmap.c:164: warning: implicit declaration of function 'mfbGetendtab'

../cfb/cfbcppl.c:390: warning: implicit declaration of function 'mfbGetpartmasks'

../cfb/cfbcppl.c:396: warning: implicit declaration of function 'mfbGetstarttab'

../cfb/cfbcppl.c:396: warning: implicit declaration of function 'mfbGetendtab'

xalloc.c:108: warning: implicit declaration of function ‘strlcpy’

./../shared/libc_wrapper.c:253: warning: implicit declaration of function 'strlcat'

./../shared/libc_wrapper.c:259: warning: implicit declaration of function 'strlcpy'

xaaInit.c:230: warning: implicit declaration of function 'miInitializeCompositeWrapper'
Comment 4 DEMAINE Benoît-Pierre, aka DoubleHP 2007-09-24 19:31:59 UTC
I think 1.4 have more imporant issues than this. I personally have not even been able to start it. Compil was hard, execution bugged very much (I had to manually recompile several drivers), but I never could get X 1.4 working. I had to mask and downgrade. I have asked for Hard Mask against 1.4 and 1.4-r1
Comment 5 Sandro Bonazzola 2007-09-25 08:20:43 UTC
(In reply to comment #4)
> I think 1.4 have more imporant issues than this. I personally have not even
> been able to start it. Compil was hard, execution bugged very much (I had to
> manually recompile several drivers), but I never could get X 1.4 working. I had
> to mask and downgrade. I have asked for Hard Mask against 1.4 and 1.4-r1

I've just re-emerged x11-drivers/xf86-input-mouse-1.2.2 and all worked fine.

CFLAGS="-march=athlon64 -O2 -pipe -fno-strict-aliasing"

[ebuild   R   ] x11-base/xorg-server-1.4-r1  USE="dri hal ipv6 nptl sdl xorg (-3dfx) -debug -dmx -kdrive -minimal -xprint" INPUT_DEVICES="evdev keyboard mouse -acecad -aiptek -calcomp -citron -digitaledge -dmc -dynapro -elo2300 -elographics -fpit -hyperpen -jamstudio -joystick -magellan -microtouch -mutouch -palmax -penmount -spaceorb -summa -synaptics -tek4957 -ur98 -vmmouse -void -wacom" VIDEO_CARDS="nv nvidia (-amd) -apm -ark -chips -cirrus -cyrix -dummy -epson -fbdev -glint -i128 (-i740) -i810 (-impact) (-imstt) -mach64 -mga -neomagic (-newport) (-nsc) -r128 -radeon -rendition -s3 -s3virge -savage -siliconmotion -sis -sisusb (-sunbw2) (-suncg14) (-suncg3) (-suncg6) (-sunffb) (-sunleo) (-suntcx) -tdfx -tga -trident -tseng -v4l (-vermilion) -vesa -vga -via -vmware -voodoo (-xgi)" 0 kB

Comment 6 Jakub Moc (RETIRED) gentoo-dev 2007-09-30 20:01:28 UTC
Please, submit this upstream, flooding users with these warning is seriously a stupid idea.