Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 16145 - eclass updates should be un-updated
Summary: eclass updates should be un-updated
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High major (vote)
Assignee: Nicholas Jones (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-02-21 11:04 UTC by SpanKY
Modified: 2003-02-24 05:29 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description SpanKY gentoo-dev 2003-02-21 11:04:06 UTC
a lot of eclass's recently were updated with this code: 
[ -z "$DESCRIPTION" ] && DESCRIPTION="blah blah" 
 
this should not have been done because it breaks certain assumptions that should 
have been left in place ... 
namely, you *always* inherit first, and then re-set whatever variables you want in 
your specific ebuild ... 
 
if an eclass set's DESCRIPTION first and then does an inherit, then the ebuild is 
broken, not the eclass ... this behavior is documented and is standard ... 
 
the resulting bug(s) can be found when you 'inherit kde-i18n' ... 
the kde-i18n eclass will then inherit kde ... 
the kde eclass will then inherit base eclass ... 
the base eclass set's the DESCRIPTION variable because it is currently empty (since 
the kde-i18n ebuild's correctly inherited before setting up *any* variables) ... 
coming back out of base eclass and kde eclass, the kde-i18n eclass attempts to do a 
DESCRIPTION setting (since they should setup the default DESCRIPTION for 
themselves, and should be overriding the variables of the parent), but cannot 
because base already set DESCRIPTION ... 
 
finallllllllly, if we implement this kind of behavior on DESCRIPTION, then we should 
do it for HOMEPAGE too and every other variable ...
Comment 1 Nicholas Jones (RETIRED) gentoo-dev 2003-02-22 08:00:05 UTC
Fixed the i18n eclass. Wasn't aware it needed to.
If it's supposed to overwrite... it should.
Comment 2 SpanKY gentoo-dev 2003-02-22 15:44:17 UTC
you're supposed to unfix all the eclass's that were changed ;) 
Comment 3 Nicholas Jones (RETIRED) gentoo-dev 2003-02-24 05:29:15 UTC
No. :)

If they are supposed to overwrite the DESCRIPTION, they should.
If it's a fill-it-in-just-because then it shouldn't modify it
unless it's empty.