161402 – revdep-rebuild doesn't catch broken deps in e.g. /usr/bin

Bug 161402 - revdep-rebuild doesn't catch broken deps in e.g. /usr/bin

Summary: revdep-rebuild doesn't catch broken deps in e.g. /usr/bin

Status:	RESOLVED INVALID

Alias:	None

Product:	Portage Development
Classification:	Unclassified
Component:	Tools (show other bugs)
Hardware:	All Linux

Importance:	High normal (vote)
Assignee:	Portage Tools Team

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2007-01-10 20:45 UTC by Frank Richter
Modified:	2007-01-10 21:34 UTC (History)
CC List:	0 users

See Also:
Package list:
Runtime testing required:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Frank Richter 2007-01-10 20:45:33 UTC

I noticed that, when updating dbus (which is used by quite a number of apps), revdep-rebuild missed a lot of broken binaries. Digging into the revdep-rebuild source, I noticed that it only finds binaries that are _at most_ executable by the user ("-perm +u+x" in the find statement). Changing that to "-perm -u+x" (ie _at least_ executable by the user), and, behold, a lot of binaries are now recognized as broken.

Reproducible: Always

Comment 1 Paul Varner (RETIRED) gentoo-dev

2007-01-10 21:06:47 UTC

Which version of gentoolkit do you have installed?

Comment 2 Frank Richter 2007-01-10 21:34:41 UTC

Hm, was 0.2.1. Sorry for the fuzz, 0.2.2 seems to be fine... as apparently the "-perm /u+x" path is used.
Anyhow, "/" matches if any of the permissions are set; while "+" may match exactly. Maybe "-u+x" would still be more preferable as the fallback permissions filter?