Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 161252 - net-im/ejabberd-1.1.2-r1 adding http_bind patch/use and sname use flag
Summary: net-im/ejabberd-1.1.2-r1 adding http_bind patch/use and sname use flag
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Tony Vroon (RETIRED)
URL: http://yo.jabber.ru/bugzilla/show_bug...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-01-10 01:30 UTC by Justin
Modified: 2007-04-11 14:37 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
full ebuild (ejabberd-1.1.2-r2.ebuild,3.89 KB, text/plain)
2007-01-10 01:32 UTC, Justin
Details
http-bind.patch (http-bind.patch,33.79 KB, patch)
2007-01-10 01:37 UTC, Justin
Details | Diff
updated patch for 1.1.3 (ejabberd.patch,5.14 KB, patch)
2007-03-26 23:53 UTC, Justin
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Justin 2007-01-10 01:30:19 UTC
Added sname use flag to change behavior of erlang node starting ejabberd in /usr/bin/ejabberd and /usr/bin/ejabberdctl

The behavior of erlang differs fundamentally when starting a beam whether -sname or -name was used. The sname use flag modifies the ejabberd script to use the corresponding argument.

I also added the http_bind patch. This has been tested on two x86 boxes and works.

Reproducible: Always
Comment 1 Justin 2007-01-10 01:32:22 UTC
Created attachment 106290 [details]
full ebuild

this is modified ebuild that has the http_bind and sname use flags
Comment 2 Justin 2007-01-10 01:37:01 UTC
Created attachment 106294 [details, diff]
http-bind.patch

The patch for http bind.

source: http://www.jabber.ru/bugzilla/show_bug.cgi?id=91
Comment 3 Tony Vroon (RETIRED) gentoo-dev 2007-03-20 10:58:22 UTC
The http-bind is not yet applied upstream, and genuine concerns were raised in November 2006 that still have not been answered. I am not willing to apply this patch to the ebuild as a result.
Could you properly document the difference between between name & sname so it can be explained in a USE-flag description.
Comment 4 Tony Vroon (RETIRED) gentoo-dev 2007-03-20 10:59:10 UTC
Comment on attachment 106294 [details, diff]
http-bind.patch

Patch not acceptable.
Comment 5 Justin 2007-03-26 23:31:14 UTC
The -sname and -name are documented at http://www.process-one.net/docs/ejabberd/guide_en.html#htoc12


the -sname will use `hostname -s` to communicate with the node. and -name will will use `hostname -f`.  I am not an erlang expert, but -name works best for me. 

Comment 6 Justin 2007-03-26 23:53:05 UTC
Created attachment 114560 [details, diff]
updated patch for 1.1.3

I have updated the patch for 1.1.3 ebuild

I have kept the sname use flag and related changes

Instead of applying the http_bind patch directly in the ebuild via a useflag, I have moved it out to a general patch dir.  Modeled after the mail-mta/netqmail patch dir. To use, just specifiy EJABBERD_PATCH_DIR in /etc/make.conf and it will slurp all patches in the dir and apply them.
Comment 7 Tony Vroon (RETIRED) gentoo-dev 2007-04-11 14:37:49 UTC
With the exception of the http_bind patch (which is not acceptable for reasons detailed above), your changes have made it into the 1.1.3-r1 ebuild of ejabberd. Thank you for your bug report :)