SpanKY/vapier@ added new source checking test to portage-utils with the last release. I failed to run said check before. Anyway I just ran it after a cvs commit from the bugs from this morn and notice the following. So in the future could we try to run a 'make check' with our patches... Thanks in advance. make check .... FAIL: src.use.xfuncs qfile.c:206: if ((qfile_args = malloc(sizeof(qfile_args_t))) == NULL) FAIL: src.style qfile.c:216: qfile.c:218: if (qfile_args->basenames != NULL qfile.c:221: if (qfile_args->dirnames != NULL qfile.c:224: if (qfile_args->realdirnames != NULL qfile.c:549: snprintf(path, _Q_PATH_MAX, "%s/%s/%s", qfile.c:574: } while(args_file != NULL && qargc == max_args); make[2]: *** [check] Error 1 make[2]: Leaving directory `/var/cvsroot/gentoo-projects/portage-utils/tests/source' make[1]: *** [check] Error 1 make[1]: Leaving directory `/var/cvsroot/gentoo-projects/portage-utils/tests' make: *** [check] Error 2
Created attachment 105939 [details, diff] qfile-cvs-1.39.diff patch to make qfile pass make check. solar@here /var/cvsroot/gentoo-projects/portage-utils $ cd tests/source/ solar@here /var/cvsroot/gentoo-projects/portage-utils/tests/source $ make ./dotest PASS: src.typos PASS: src.obsolete.funcs PASS: src.bad.constants PASS: src.obsolete.headers PASS: src.use.xfuncs PASS: src.style
solar@here /var/cvsroot/gentoo-projects/portage-utils $ cvs ci -m "- make check should not fail. bug 160767" ? scripts /var/cvsroot/gentoo-projects/portage-utils/qfile.c,v <-- qfile.c new revision: 1.40; previous revision: 1.39
