160343 – common-lisp-common.eclass pollutes environment (nullglob)

Bug 160343 - common-lisp-common.eclass pollutes environment (nullglob)

Summary: common-lisp-common.eclass pollutes environment (nullglob)

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Eclasses (show other bugs)
Hardware:	All All

Importance:	High critical (vote)
Assignee:	Common Lisp Bugs

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2007-01-05 17:02 UTC by SpanKY
Modified:	2007-06-21 17:47 UTC (History)
CC List:	2 users (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
common-lisp-common.eclass.patch (common-lisp-common.eclass.patch,698 bytes, patch) 2007-06-21 16:10 UTC, Steve L	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description SpanKY gentoo-dev

2007-01-05 17:02:48 UTC

the reregister-all-common-lisp-implementations function sets nullglob but fails to restore the environment the way it found it

for the proper way to do things, consider the eutils code:
local shopts=$-
set -o noglob #so that bash doesn't expand "*"
...
set +o noglob; set -$shopts #reset old shell opts

Comment 1 Steve L 2007-06-21 16:10:54 UTC

Created attachment 122706 [details, diff]
common-lisp-common.eclass.patch

Patch will restore nullglob to whatever it was before the function was called. 
HTH.

Comment 2 Marijn Schouten (RETIRED) gentoo-dev

2007-06-21 17:40:10 UTC

Thanks for the patch Steve. I've committed it except for the first test which is redundant.

I noticed that the same function also changes the working directory. Not sure if this is intentional. I've left it alone for now.

Comment 3 Marijn Schouten (RETIRED) gentoo-dev

2007-06-21 17:47:22 UTC

I've added a "cd - >/dev/null" for the cd issue.