Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 160339 - ruby.eclass screws up environment (nullglob)
Summary: ruby.eclass screws up environment (nullglob)
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Eclasses (show other bugs)
Hardware: All All
: High critical (vote)
Assignee: Gentoo Ruby Team
URL:
Whiteboard:
Keywords:
: 160437 (view as bug list)
Depends on:
Blocks:
 
Reported: 2007-01-05 16:57 UTC by SpanKY
Modified: 2007-01-12 22:33 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
ruby.eclass typo fix (ruby.eclass.patch,498 bytes, text/plain)
2007-01-12 22:33 UTC, Paul Varner (RETIRED)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description SpanKY gentoo-dev 2007-01-05 16:57:02 UTC
by overloading the prepall function and polluting the env, the ruby.eclass breaks portage code

this may manifest itself in the new qa checks seeming to throw false positives

the relevant laziness:
        # in case no directories found in siteruby
        shopt -sq nullglob

ive you're going to screw with shell options, you need to restore things the way you found it
Comment 1 SpanKY gentoo-dev 2007-01-05 17:00:17 UTC
for the proper way to do things, consider the eutils code:
local shopts=$-
set -o noglob #so that bash doesn't expand "*"
...
set +o noglob; set -$shopts #reset old shell opts
Comment 2 Diego Elio Pettenò (RETIRED) gentoo-dev 2007-01-06 15:35:10 UTC
*** Bug 160437 has been marked as a duplicate of this bug. ***
Comment 3 Diego Elio Pettenò (RETIRED) gentoo-dev 2007-01-06 16:00:29 UTC
Thanks Mike, fixed now.
Comment 4 Paul Varner (RETIRED) gentoo-dev 2007-01-12 22:33:08 UTC
Created attachment 106736 [details]
ruby.eclass typo fix

The "fixed" version of the eclass has an error. If no one else fixs it in the next day or so, I'll go ahead and fix it myself.