Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 159994 - vblade version bump request (includes ebuilds)
Summary: vblade version bump request (includes ebuilds)
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Robin Johnson
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-01-04 09:28 UTC by slynn@granite-mtn.net
Modified: 2007-03-07 19:50 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
version 14 ebuild - initial submission (vblade-14.ebuild,1.03 KB, text/plain)
2007-01-04 09:30 UTC, slynn@granite-mtn.net
Details
fix to init stop script fixing bug #137016 (init.d-vblade.vblade0,2.59 KB, text/plain)
2007-01-04 09:31 UTC, slynn@granite-mtn.net
Details

Note You need to log in before you can comment on or make changes to this bug.
Description slynn@granite-mtn.net 2007-01-04 09:28:55 UTC
Coraid's vblade is now on version 14.  Gentoo's portage contains version 10.  After looking at the code and ebuild I made minor changes in the ebuild (the source seems to be a tgz now and not a tar.gz and I'm not sure if my way is the best way to handle this).  I have also included a fix for bug #137016 (this fix referenced in that bug).


The new ebuild has been installed/uninstalled and I have performed the following basic testing:

1. exported two devices and mounted them remotely
2. started both devices and stopped one to ensure the init script is working

All seems to "work well for me".  

WRT the init script...  The source of the original problem was that the stop
script did not check for the specific exported version, even though the ${@} was supposed to perform this function.  My fix is simple, but I'm not sure that this is the correct way to fix the problem.  As with jabberd2 a while back, having a Gentoo init script call a bash script which wraps the launch is probably a bad idea.  We don't really have fine grained control over the vblade process because it's parent process is a bash shell.  It's hard to ensure error control IMHO.
Comment 1 slynn@granite-mtn.net 2007-01-04 09:30:39 UTC
Created attachment 105394 [details]
version 14 ebuild - initial submission

not really much changed except in name from v10 ebuild
Comment 2 slynn@granite-mtn.net 2007-01-04 09:31:27 UTC
Created attachment 105395 [details]
fix to init stop script fixing bug #137016
Comment 3 Robin Johnson archtester Gentoo Infrastructure gentoo-dev Security 2007-03-07 19:50:04 UTC
in cvs.