Bug 159832 – pointless duplication of use.mask entries

• Status: RESOLVED CANTFIX
• Product: Gentoo Linux

[Description Jakub Moc (RETIRED) 2007-01-03 04:34:59 UTC]

This just doesn't make sense, use.mask it in base/ and unmask on x86 profiles *only*...

- useflag 'sybase-ct' masked in 50 profiles.
- useflag 'solid' masked in 50 profiles.
- useflag 'birdstep' masked in 50 profiles.
- useflag 'adabas' masked in 50 profiles.
- useflag 'pfpro' masked in 50 profiles.
- useflag 'informix' masked in 50 profiles.
- useflag 'empress' masked in 50 profiles.
- useflag 'empress-bcs' masked in 50 profiles.
- useflag 'frontbase' masked in 50 profiles.
- useflag 'dbmaker' masked in 50 profiles.
- useflag 'sybase' masked in 50 profiles.

An example how it looks now:

profiles/default-bsd/use.mask:64:sybase-ct
profiles/selinux/ppc/use.mask:42:sybase-ct
profiles/selinux/mips/use.mask:264:sybase-ct
profiles/selinux/amd64/use.mask:115:sybase-ct
profiles/selinux/alpha/use.mask:61:sybase-ct
profiles/selinux/sparc/use.mask:94:sybase-ct
profiles/selinux/2005.1/amd64/use.mask:53:sybase-ct
profiles/selinux/2005.1/alpha/use.mask:63:sybase-ct
profiles/default-linux/ppc/2005.1/ppc64/use.mask:50:sybase-ct
profiles/default-linux/ppc/use.mask:42:sybase-ct
profiles/default-linux/ia64/use.mask:45:sybase-ct
profiles/default-linux/m68k/use.mask:30:sybase-ct
profiles/default-linux/hppa/use.mask:213:sybase-ct
profiles/default-linux/mips/use.mask:268:sybase-ct
profiles/default-linux/s390/use.mask:45:sybase-ct
profiles/default-linux/amd64/use.mask:111:sybase-ct
profiles/default-linux/alpha/use.mask:61:sybase-ct
profiles/default-linux/ppc64/use.mask:52:sybase-ct
profiles/default-linux/sparc/use.mask:95:sybase-ct
profiles/hardened/ppc/use.mask:40:sybase-ct
profiles/hardened/amd64/use.mask:110:sybase-ct
profiles/hardened/ppc64/use.mask:55:sybase-ct
profiles/default-darwin/use.mask:23:sybase-ct

Same for the rest of the flags above.

[Comment 1 Jakub Moc (RETIRED) 2007-01-03 04:37:28 UTC]

- useflag 'esoob' masked in 49 profiles.
- useflag 'mzscheme' masked in 48 profiles.
- useflag 'afs' masked in 48 profiles.

[Comment 2 Chris Gianelloni (RETIRED) 2007-01-03 19:13:49 UTC]

Feel free to provide a patch and I'll change them all.

[Comment 3 Diego Elio Pettenò (RETIRED) 2007-01-04 12:40:10 UTC]

I'll handle them, as I improved my script to tell me where an useflag is unmasked, too.

[Comment 4 Diego Elio Pettenò (RETIRED) 2007-01-04 14:06:04 UTC]

After cleaning up all PHP useflags, this is the list:

Tracking 57 main profiles
- useflag 'djbfft' masked in 33 profiles.
- useflag 'lm_sensors' masked in 42 profiles.
- useflag 'lirc' masked in 32 profiles.
- useflag 'mzscheme' masked in 47 profiles.
- useflag 'kqemu' masked in 41 profiles.
- useflag 'apm' masked in 33 profiles.
- useflag '3dfx' masked in 50 profiles.
- useflag 'acpi' masked in 33 profiles.
- useflag 'multilib' masked in 53 profiles.
- useflag 'wifi' masked in 31 profiles.
- useflag 'pike' masked in 36 profiles.
- useflag 'emboss' masked in 29 profiles.
- useflag 'java' masked in 36 profiles.
- useflag 'directfb' masked in 30 profiles.
- useflag 'mono' masked in 40 profiles.
- useflag 'gulm' masked in 44 profiles.
- useflag 'hal' masked in 30 profiles.
- useflag 'pda' masked in 30 profiles.
- useflag 'acl' masked in 29 profiles.
- useflag 'x264' masked in 34 profiles.
- useflag 'jack' masked in 31 profiles.
- useflag 'afs' masked in 48 profiles.
- useflag 'pcmcia' masked in 34 profiles.
- useflag 'cman' masked in 44 profiles.
- useflag 'netbeans' masked in 32 profiles.
- useflag 'clvm' masked in 48 profiles.
- useflag 'tcc' masked in 41 profiles.

[Comment 5 Luca Barbato 2007-01-04 16:02:14 UTC]

kqemu cleaned

[Comment 6 Chris Gianelloni (RETIRED) 2007-02-19 19:27:14 UTC]

If anyone does any further work on this, can they send me a .diff so I can apply it to my release snapshot?

Thanks,

[Comment 7 Andrej Kacian (RETIRED) 2007-03-27 12:06:58 UTC]

(In reply to comment #3)
> I'll handle them, as I improved my script to tell me where an useflag is
> unmasked, too.
> 

Diego, care to share the script please?

[Comment 8 Diego Elio Pettenò (RETIRED) 2007-03-27 13:53:01 UTC]

Created attachment 114620 [details]
useflags-report.rb

Here it is. Yes it is ruby.

[Comment 9 Chris Gianelloni (RETIRED) 2007-03-27 15:09:15 UTC]

Thanks...

If nobody minds, I'd prefer this get left alone until after the release, so we don't have to go hacking up the snapshot even more.  I'll even take charge of this and get it done myself.

[Comment 10 Christian Faulhammer (RETIRED) 2007-04-06 21:05:02 UTC]

x86 stable

[Comment 11 Christian Faulhammer (RETIRED) 2007-04-06 21:05:23 UTC]

(In reply to comment #10)
> x86 stable
 wrong bug, readding x86

[Comment 12 Chris Gianelloni (RETIRED) 2007-06-21 19:30:29 UTC]

$ useflags-report.rb 
/home/wolf31o2/bin/useflags-report.rb:19: undefined method `require_gem' for main:Object (NoMethodError)

What am I missing?

[Comment 13 Richard Brown (RETIRED) 2007-06-21 20:43:45 UTC]

(In reply to comment #12)
> $ useflags-report.rb 
> /home/wolf31o2/bin/useflags-report.rb:19: undefined method `require_gem' for
> main:Object (NoMethodError)
> 
> What am I missing?
> 

emerge rubygems

and maybe 

gem install getopt

as there doesn't seem to be an ebuild for it.

[Comment 14 Chris Gianelloni (RETIRED) 2007-06-21 22:31:58 UTC]

# gem install getopt
Bulk updating Gem source index for: http://gems.rubyforge.org
ERROR:  While executing gem ... (Gem::GemNotFoundException)
    Could not find getopt (> 0) in any repository

Close, but no cigar.  Any other ideas?

[Comment 15 Diego Elio Pettenò (RETIRED) 2007-06-22 09:58:38 UTC]

getopt it's in my overlay at git://flameeyes.is-a-geek.org/overlay.git

[Comment 16 Chris Gianelloni (RETIRED) 2007-06-22 19:01:08 UTC]

OK.  I've got this going now and am starting to work through the remaining USE flags.  I'll close this bug once I get them all done.  Thanks for the script, Diego, and thanks to everyone else for the help.

[Comment 17 Christian Faulhammer (RETIRED) 2007-09-24 18:19:05 UTC]

(In reply to comment #16)
> OK.  I've got this going now and am starting to work through the remaining USE
> flags.  I'll close this bug once I get them all done.  Thanks for the script,
> Diego, and thanks to everyone else for the help.

 Is there any movement here Chris (wolf) or do you need help with it?

[Comment 18 Chris Gianelloni (RETIRED) 2007-10-09 22:22:20 UTC]

Sorry about this... I've been a bit swamped... I'll get onto this shortly...

[Comment 19 Dawid Węgliński (RETIRED) 2007-11-07 19:18:24 UTC]

Created attachment 135442 [details, diff]
patch for use.mask files

Ok, for last 2 or 3 hours i've been running loop

for i in $(vgrep use.mask ); do grep '^${i}$' $(parent)/use.mask; done

in every directory in $CVSROOT/profiles/*/*/*/*... (starting from child directories) and manually removing duplicate entries from. vgrep() is just an alias for grep -v '^#'. Someone please check it ;)

[Comment 20 Chris Gianelloni (RETIRED) 2007-11-08 02:02:21 UTC]

It looks good, so far.  I'll need to verify it, but it seems correct from my quick once over.

[Comment 21 Dawid Węgliński (RETIRED) 2007-12-08 18:56:10 UTC]

Thanks

[Comment 22 Dawid Węgliński (RETIRED) 2007-12-23 22:41:35 UTC]

Ok, this is going nowhere. Please mark it fixed or something as most things were cleared. x86 is off.

[Comment 23 Jakub Moc (RETIRED) 2007-12-23 22:58:20 UTC]

Marking CANTFIX as a reporter of this bug. 

(And no, nor me, nor cla intend to waste more time producing patches on a target that's moving on a daily bases only for the patch to get subsequently ignored for over a month, rendering it totally useless.)

[Comment 24 Chris Gianelloni (RETIRED) 2008-02-14 01:25:17 UTC]

By the way, this will be "fixed" on its own with 2008.0 and the multi-parent profiles being introduced, at least for default-linux (default/linux) and hardened (hardened/linux, actually)...