Bug 159787 – postfix ebuild shouldn't overwrite home_mailbox in main.cf

• Status: VERIFIED WORKSFORME
• Product: Gentoo Linux

[Description Iain Buchanan 2007-01-02 15:32:33 UTC]

Every time I upgrade postfix, the new configuration file has a line at the end:

home_mailbox = .maildir/

If this line is to be in main.cf, it should at least be with the other home_mailbox examples, around line 408 (in postfix-2.3.5)

However, I believe it shouldn't even be in there at all.  ~/.maildir is not what _everyone_ uses, therefore it should be up to those who want it to add it.

thoughts?  thanks.

postfix-2.3.5 (and previous).
emerge --info:

Portage 2.1.2_rc4-r4 (default-linux/x86/2006.0, gcc-3.4.6, glibc-2.5-r0, 2.6.19-suspend2-r1 i686)
=================================================================
System uname: 2.6.19-suspend2-r1 i686 Intel(R) Pentium(R) 4 CPU 3.00GHz
Gentoo Base System version 1.12.8
Last Sync: Mon, 01 Jan 2007 23:30:02 +0000
distcc 2.18.3 i686-pc-linux-gnu (protocols 1 and 2) (default port 3632) [disabled]
dev-java/java-config: 1.3.7, 2.0.31
dev-lang/python:     2.3.6, 2.4.4
dev-python/pycrypto: 2.0.1-r5
sys-apps/sandbox:    1.2.18.1
sys-devel/autoconf:  2.13, 2.61
sys-devel/automake:  1.4_p6, 1.5, 1.6.3, 1.7.9-r1, 1.8.5-r3, 1.9.6-r2, 1.10
sys-devel/binutils:  2.17
sys-devel/gcc-config: 1.3.14
sys-devel/libtool:   1.5.22
virtual/os-headers:  2.6.19
ACCEPT_KEYWORDS="x86 ~x86"
AUTOCLEAN="yes"
CBUILD="i686-pc-linux-gnu"
CFLAGS="-O2 -march=pentium4 -pipe"
CHOST="i686-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/kde/3.5/env /usr/kde/3.5/share/config /usr/kde/3.5/shutdown /usr/share/X11/xkb /usr/share/config"
CONFIG_PROTECT_MASK="/etc/env.d /etc/env.d/java/ /etc/gconf /etc/java-config/vms/ /etc/revdep-rebuild /etc/splash /etc/terminfo /etc/texmf/web2c"
CXXFLAGS="-O2 -march=pentium4 -pipe"
DISTDIR="/usr/portage/distfiles"
FEATURES="autoconfig distlocks fixpackages metadata-transfer sandbox sfperms strict userfetch userpriv usersandbox"
GENTOO_MIRRORS="http://public.planetmirror.com/pub/gentoo/ http://mirror.pacific.net.au/linux/Gentoo ftp://ftp.swin.edu.au/gentoo ftp://gg3.net/pub/linux/gentoo/ ftp://gentoo.ccccom.com ftp://ftp.ussg.iu.edu/pub/linux/gentoo"
LANG="en_AU.UTF-8"
LINGUAS="en_AU en en_GB en_US"
MAKEOPTS="-j3"
PKGDIR="/usr/portage/packages"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --delete-after --stats --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/usr/local/portage /usr/local/overlays/xgl-coffee /usr/local/overlays/gnome-experimental"
SYNC="rsync://rsync.gentoo.org/gentoo-portage"
USE="X aac acpi aiglx alsa apache2 arts berkdb bitmap-fonts cli cracklib crypt cups dbus dlloader dri eds emboss encode esd ffmpeg foomaticdb fortran gdbm gif gnome gpm gstreamer gtk gtk2 hal iconv imlib ipv6 isdnlog jpeg libg++ libwww mad mikmod motif mp3 mpeg ncurses nls nptl nptlonly ogg opengl pam pcre perl png pppd python quicktime readline reflection samba sdl session smb spell spl ssl tcpd truetype truetype-fonts type1-fonts udev vorbis x86 xml xorg xv zlib" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" ALSA_PCM_PLUGINS="adpcm alaw asym copy dmix dshare dsnoop empty extplug file hooks iec958 ioplug ladspa lfloat linear meter mulaw multi null plug rate route share shm softvol" ELIBC="glibc" INPUT_DEVICES="keyboard mouse synaptics" KERNEL="linux" LINGUAS="en_AU en en_GB en_US" USERLAND="GNU" VIDEO_CARDS="ati radeon vesa fbdev fglrx"
Unset:  CTARGET, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LC_ALL, LDFLAGS, PORTAGE_RSYNC_EXTRA_OPTS

[Comment 1 Jakub Moc (RETIRED) 2007-01-02 15:37:18 UTC]

(In reply to comment #0)
> thoughts?  thanks.

Thoughts? That's what CONFIG_PROTECT is for; it you dislike the defaults, then don't let them overwrite your custom config.

[Comment 2 Iain Buchanan 2007-01-02 17:53:11 UTC]

(In reply to comment #1)
> (In reply to comment #0)
> > thoughts?  thanks.
> 
> Thoughts? That's what CONFIG_PROTECT is for; it you dislike the defaults, then
> don't let them overwrite your custom config.

I beg to disagree :) sure CONFIG_PROTECT is good if I have wildly differing config files, but in this case I think the default needs to be changed.  I don't want to miss changes to the config file in other areas (such as readme_directory, which changes with every version).

My arguement is that "home_mailbox = .maildir/" is at the very least placed in the wrong spot - why is it not with the other home_mailbox examples?  This is confusing to new users (I remember it took me some time to find it the first time).

thanks.

[Comment 3 Jakub Moc (RETIRED) 2007-01-03 02:28:50 UTC]

(In reply to comment #2)
> My arguement is that "home_mailbox = .maildir/" is at the very least placed in
> the wrong spot - why is it not with the other home_mailbox examples? 

Because that's how postconf works, so if you want that changed, you'll need to complain upstream.

[Comment 4 Iain Buchanan 2007-01-03 22:13:47 UTC]

actually, on closer inspection, it comes from the ebuild:

	if use mbox ; then
		mypostconf="mail_spool_directory=/var/spool/mail"
	else
		mypostconf="home_mailbox=.maildir/"
	fi

I'm still not convinced this is the "Right Way" to do it...

[Comment 5 Jakub Moc (RETIRED) 2007-01-04 00:17:56 UTC]

(In reply to comment #4)
> actually, on closer inspection, it comes from the ebuild:

Of course it comes from ebuild; it needs to default to something. And postconf sticks it to the end of main.cf. Customize as you need, you have CONFIG_PROTECT, nothing will get overwritten unless you ask for it.

Nothing to fix here.