Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 158933 - Fix ebuilds to use elog instead of einfo
Summary: Fix ebuilds to use elog instead of einfo
Status: RESOLVED WONTFIX
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Enhancement/Feature Requests (show other bugs)
Hardware: All Other
: High enhancement
Assignee: Gentoo Quality Assurance Team
URL:
Whiteboard:
Keywords:
Depends on: 199464
Blocks:
  Show dependency tree
 
Reported: 2006-12-23 10:06 UTC by Xake
Modified: 2009-05-02 03:38 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Xake 2006-12-23 10:06:25 UTC
I think the possibility to only have the choices of "info, warn, error, log" are a bit wrong.
Why?

I have all these mailed to me mostly becouse the possibility to catch messages like:
***
INFO: postinst
~/.wine/config is now deprecated.  For configuration either use
winecfg or regedit HKCU\Software\Wine
***

the BAD part with having INFO in your choices is that you got A LOT of messages without any purpose like a mail only containing 
***
INFO: postrm
Updating scrollkeeper database ...
Updating desktop mime database ...
Updating shared mime info database ...
Updating icons cache ...
*** (this from the postemerge cleanup-unmerge from lifrea)

The ponit is: there is a lot of messages (like the one above from wine) that is nice to have, but a lot (like the postrm from liferea) that is not needed for me.
I think it would be nice to maybe make it possible to choose also from what part of the process you want the INFO (and thus also have the possibility to not have all the messages only containing info about a successfully patch).
Comment 1 Marius Mauch (RETIRED) gentoo-dev 2006-12-25 07:44:08 UTC
This is (hopefully) a transitory issue: the LOG level didn't exist before elog was introduced, so most ebuilds still use INFO while they should use LOG. I already have a list of ebuilds to check for potential conversion that I plan to work on next year.
A seconf filter is of course another option, but I'd rather avoid the additional (configuration, not code) complexity introduced by it.
Comment 2 Xake 2006-12-25 08:54:04 UTC
Oh, I see. I could understand then why you do not want an additional filter then.

Maybe do a tracker-bug for ebuilds not yet migrated?
Either list them here or do seperate bugs blocking that one bug?
Comment 3 Marius Mauch (RETIRED) gentoo-dev 2007-01-02 16:18:01 UTC
Too many packages for that yet (current list includes ~1900 packages, but that includes a number of false positives). You can see the current list at dev.gentoo.org/~genone/reports/einfo 
Comment 4 Xake 2007-10-25 10:48:29 UTC
How goes the work on this?
Is there someone working on it?

Can I attach patches for ebuilds I find or should I just point them out here?
Like sys-kernel/gentoo-sources is pretty obvious...
Comment 5 Marius Mauch (RETIRED) gentoo-dev 2007-10-25 16:44:04 UTC
I had been processing the list, but stopped somewhere in net-*, partially because I got distracted with other things (like portage-2.2 ;) and partially because it's a really boring job. And unfortunately patches don't really help here as it doesn't make much of a difference if I apply a patch or change the stuff myself, it's all the other stuff that's the real drain (looking up package names, cvs update, changelog update, commit, ...), even though I already have it mostly scripted already. It's ok for one, two or even a dozen packages, but after dealing with several hundred packages this way I burned out on that front.
Comment 6 Xake 2007-10-25 16:52:15 UTC
So with other word it may be better to make bugs for each package I found, and bug their devs?
Comment 7 Bo Ørsted Andresen (RETIRED) gentoo-dev 2008-02-26 07:11:14 UTC
(In reply to comment #3)
> Too many packages for that yet (current list includes ~1900 packages, but
> that includes a number of false positives). You can see the current list at
> dev.gentoo.org/~genone/reports/einfo 

What we need is a way for maintainers to remove false positives from a list like this.

(In reply to comment #5)
[...]

Maybe the qa team can help here?
Comment 8 Marius Mauch (RETIRED) gentoo-dev 2008-02-26 08:05:32 UTC
(In reply to comment #7)
> (In reply to comment #3)
> > Too many packages for that yet (current list includes ~1900 packages, but
> > that includes a number of false positives). You can see the current list at
> > dev.gentoo.org/~genone/reports/einfo 
> 
> What we need is a way for maintainers to remove false positives from a list
> like this.

Well, my script[1] (called by another wrapper script setting $WHITELIST) for generating those lists has whitelist functionality already.

[1] http://sources.gentoo.org/viewcvs.py/portage/private/genone/scripts/einfo-check.sh
Comment 9 Xake 2008-02-26 08:53:02 UTC
I think it would be wise to fix eclasses first since one eclass could fix the behavior of many ebuilds.
Bug #199464 was me trying to do something about kernel-2.eclass, but since there is no feedback on my question I came to a stall.
Comment 10 Mark Loeser (RETIRED) gentoo-dev 2009-05-02 03:38:52 UTC
This has gone no where.