Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 158814 - net-wireless/ipw3945d-1.7.22-r4 /etc/init.d/ipw3945d uses illegal "exit 1"
Summary: net-wireless/ipw3945d-1.7.22-r4 /etc/init.d/ipw3945d uses illegal "exit 1"
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Christian Heim (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-12-22 01:59 UTC by Magnus Ahlberg
Modified: 2006-12-22 02:14 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Magnus Ahlberg 2006-12-22 01:59:20 UTC
When trying to get the new ipw3945d-1.7.22-r4 working correctly I once ran "modprobe ipw3945" and got the following message:

 * The pidfile (/var/run/ipw3945d/ipw3945d.pid) is still present.
 * Please check that the daemon isn't running!
 * DO NOT USE EXIT IN INIT.D SCRIPTS
 * This IS a bug, please fix your broken init.d
FATAL: Error running install command for ipw3945

And sure enough, the /etc/init.d/ipw3945d init-script uses "exit 1" in it's check-function, I'm guessing that this should be changed to "return 1" or something?
Comment 1 Christian Heim (RETIRED) gentoo-dev 2006-12-22 02:14:04 UTC
(In reply to comment #0)
> When trying to get the new ipw3945d-1.7.22-r4 working correctly I once ran
> "modprobe ipw3945" and got the following message:
> 
>  * The pidfile (/var/run/ipw3945d/ipw3945d.pid) is still present.
>  * Please check that the daemon isn't running!
>  * DO NOT USE EXIT IN INIT.D SCRIPTS
>  * This IS a bug, please fix your broken init.d
> FATAL: Error running install command for ipw3945
> 
> And sure enough, the /etc/init.d/ipw3945d init-script uses "exit 1" in it's
> check-function, I'm guessing that this should be changed to "return 1" or
> something?
> 

You are right, I didn't knew using `exit 1' is forbidden nowadays inside the init-script when I wrote the init.d file. Thanks to you, it should be fixed now. Will be on the mirrors on the next sync.