Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 158727 - update for app-pda/dopi to 0.3.4
Summary: update for app-pda/dopi to 0.3.4
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High enhancement
Assignee: dotnet project
URL: http://www.snorp.net/log/dopi/
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-12-21 06:02 UTC by Dieter Verfaillie
Modified: 2007-02-07 00:35 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
ebuild for dopi 0.3.4 (dopi-0.3.4.ebuild,741 bytes, text/plain)
2006-12-21 06:05 UTC, Dieter Verfaillie
Details
added >=dev-dotnet/glade-sharp-2.4.0 to DEPEND (dopi-0.3.4-r1.ebuild,773 bytes, text/plain)
2006-12-25 04:52 UTC, Dieter Verfaillie
Details
dopi-0.3.4-r2.ebuild (dopi-0.3.4-r2.ebuild,784 bytes, text/plain)
2007-02-05 23:15 UTC, Dieter Verfaillie
Details
The missing icon exception fix (noicon-exception-fix.diff,557 bytes, patch)
2007-02-06 02:31 UTC, Jurek Bartuszek (RETIRED)
Details | Diff
dopi-0.3.4.ebuild (dopi-0.3.4.ebuild,876 bytes, text/plain)
2007-02-06 21:58 UTC, Dieter Verfaillie
Details
noicon-exception-fix.diff (noicon-exception-fix.diff,572 bytes, patch)
2007-02-06 22:04 UTC, Dieter Verfaillie
Details | Diff
noicon-exception-fix.diff (noicon-exception-fix.diff,579 bytes, patch)
2007-02-06 22:37 UTC, Dieter Verfaillie
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dieter Verfaillie 2006-12-21 06:02:40 UTC
dopi has been updated to 0.3.4 since Oct 23
Comment 1 Dieter Verfaillie 2006-12-21 06:05:30 UTC
Created attachment 104506 [details]
ebuild for dopi 0.3.4

It no longer supports parallel building, otherwise you would get this:
Making all in taglib-sharp
make[1]: Entering directory `/var/tmp/portage/app-pda/dopi-0.3.4/work/dopi-0.3.4/taglib-sharp'
/usr/bin/gmcs -debug -out:../taglib-sharp/taglib-sharp.dll -target:library -r:Mono.Posix ./TagLib/*.cs ./TagLib/*/*.cs ./TagLib/*/*/*.cs
make[1]: *** No rule to make target `../taglib-sharp/taglib-sharp.dll.mdb', needed by `all-am'.  Stop.
Comment 2 Sideris Michael 2006-12-24 18:31:38 UTC
May I add here that dopi needs glade-sharp as well in order to compile. So, you might wanna add it to the DEPEND list.
Comment 3 Dieter Verfaillie 2006-12-25 04:52:18 UTC
Created attachment 104708 [details]
added >=dev-dotnet/glade-sharp-2.4.0 to DEPEND

First of all, a Merry Christmas to you all :)

Indeed, src/Makefile.am has glade-sharp-2.0 in DOPI_ASSEMBLIES. Thanks for catching that.
Comment 4 Jurek Bartuszek (RETIRED) gentoo-dev 2007-02-05 00:40:05 UTC
Thanks for posting the ebuild. Few more things to do here:

1. Fix the header (see /usr/portage/skel.ebuild)
2. You could use ${PN} in SRC_URI instead of "dopi"
3. Rather than setting 'MAKEOPTS="${MAKEOPTS} -j1"' declare src_compile() and call 'emake -j1 || die ...' inside it (of course you still have to call econf as well ;))
4. I think you should update the desktop database after unmerging the package as well (pkg_postrm())
Comment 5 Dieter Verfaillie 2007-02-05 23:15:03 UTC
Created attachment 109285 [details]
dopi-0.3.4-r2.ebuild

Glad to be of help :)

1. Done. Also fixed copyright year.

2. Done.

3. Correct! I wasn't sure what method to use, as both can be found
in lot's of packages in the tree. However, the ebuild howto specifies
your method for the emake command (http://www.gentoo.org/proj/en/devrel/handbook/handbook.xml?part=2&chap=1#doc_chap4).
Fixed :)

4. It's already there, in pkg_postinst(). I copied that technique from other
ebuilds in the tree. In fact, I couldn't find any ebuild doing it in pkg_postrm().
I did, however, forget to add fdo-mime_mime_database_update, as the
.desktop file specifies MimeType=... Also fixed.
Comment 6 Jurek Bartuszek (RETIRED) gentoo-dev 2007-02-06 02:31:10 UTC
Ok, builds fine now. However, when there is no gnome-dev-ipod icon in the default icon theme you get an exception:

Unhandled Exception: GLib.GException: Icon 'gnome-dev-ipod' not present in theme
  at Gtk.IconTheme.LoadIcon (System.String icon_name, Int32 size, IconLookupFlags flags) [0x00000]
  at Dopi.DopiWindow..ctor () [0x00000]
  at Dopi.EntryPoint.Main (System.String[] args) [0x00000]

Software that throws an exception whenever an icon is missing is evil. Try adding the patch (just wrote it) to your ebuild. It's already been sent upstream.

Oh, and if there is no good reason (and that's the case) for appending r2 to the version of initial ebuild, simply drop it ;)
Comment 7 Jurek Bartuszek (RETIRED) gentoo-dev 2007-02-06 02:31:53 UTC
Created attachment 109294 [details, diff]
The missing icon exception fix
Comment 8 Dieter Verfaillie 2007-02-06 21:58:09 UTC
Created attachment 109378 [details]
dopi-0.3.4.ebuild

- apply noicon-exception-fix
- remove -rx suffix for bugzilla -> artifact from my local overlay ;)
Comment 9 Dieter Verfaillie 2007-02-06 22:04:04 UTC
Created attachment 109381 [details, diff]
noicon-exception-fix.diff

Don't catch everything, only GLib.GException.
Not yet sent upstream, let's see what you think first...
Comment 10 Dieter Verfaillie 2007-02-06 22:17:46 UTC
Comment on attachment 109381 [details, diff]
noicon-exception-fix.diff

oops, shouldn't be here yet
Comment 11 Dieter Verfaillie 2007-02-06 22:37:15 UTC
Created attachment 109384 [details, diff]
noicon-exception-fix.diff

Don't catch everything, only GLib.GException.
Should have been here, sorry for the confusion.
I'll go sleep now :)
Comment 12 Jurek Bartuszek (RETIRED) gentoo-dev 2007-02-07 00:35:04 UTC
Ok. Fixed in CVS, thanks! And do not hesitate to send the patch to upstream as well.