Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 158328 - baselayout does not force C locale when unmounting
Summary: baselayout does not force C locale when unmounting
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] baselayout (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords: InVCS
Depends on:
Blocks:
 
Reported: 2006-12-16 15:24 UTC by Petteri Räty (RETIRED)
Modified: 2006-12-20 10:17 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch for baselayout trunk to fix it (baselayout-umountorder.patch,931 bytes, patch)
2006-12-16 15:25 UTC, Petteri Räty (RETIRED)
Details | Diff
Last one was borked. (baselayout-umount-order.patch,402 bytes, patch)
2006-12-16 15:26 UTC, Petteri Räty (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Petteri Räty (RETIRED) gentoo-dev 2006-12-16 15:24:03 UTC
betelgeuse@pena ~/test $ get_mounts  | sort -ur
/var/tmp/portage /dev/raid0/portagetmp reiserfs rw,noatime
/var/lib/ccache /dev/raid0/ccache reiserfs rw,noatime
/var/distfiles aria:/usr/src/distfiles nfs rw,vers=3,rsize=32768,wsize=32768,hard,proto=udp,timeo=7,retrans=3,sec=sys,addr=aria
/var /dev/raid1/var reiserfs rw,noatime
/usr/src /dev/raid0/linuxsrc reiserfs rw,noatime
/usr/portage /dev/sata/portage reiserfs rw,noatime
/usr /dev/raid1/usr reiserfs rw,noatime
/sys sysfs sysfs rw,nosuid,nodev,noexec
/proc proc proc rw,nosuid,nodev,noexec
/proc/bus/usb usbfs usbfs rw
/opt /dev/raid1/opt reiserfs rw,noatime
/mnt/sata /dev/sda6 ntfs ro,uid=1000,gid=0,fmask=0177,dmask=077,nls=utf8,errors=continue,mft_zone_multiplier=1
/mnt/checkouts /dev/raid0/co reiserfs rw,noatime
/lib/rcscripts/init.d none tmpfs rw,nosuid,nodev,noexec
/home /dev/raid1/home reiserfs rw,noatime
/home/betelgeuse/scifi /dev/raid1/scifi ext3 rw,nosuid,nodev,noexec,noatime,data=ordered
/home/betelgeuse/scifi2 /dev/raid1/scifi2 reiserfs rw,nosuid,nodev,noexec,noatime
/home/betelgeuse/images /dev/maxtor/images reiserfs rw,nosuid,nodev,noexec,noatime
/home/betelgeuse/btdown /dev/raid0/btdown reiserfs rw,nosuid,nodev,noatime
/dev udev ramfs rw,nosuid
/dev/shm none tmpfs rw
/ /dev/root reiserfs rw,noatime
/dev/pts devpts devpts rw,nosuid,noexec

The order for /home/betelgeuse stuff is obviously wrong here. Fixed:

betelgeuse@pena ~/test $ get_mounts  | sort -u -k 1,1br
/var/tmp/portage /dev/raid0/portagetmp reiserfs rw,noatime
/var/lib/ccache /dev/raid0/ccache reiserfs rw,noatime
/var/distfiles aria:/usr/src/distfiles nfs rw,vers=3,rsize=32768,wsize=32768,hard,proto=udp,timeo=7,retrans=3,sec=sys,addr=aria
/var /dev/raid1/var reiserfs rw,noatime
/usr/src /dev/raid0/linuxsrc reiserfs rw,noatime
/usr/portage /dev/sata/portage reiserfs rw,noatime
/usr /dev/raid1/usr reiserfs rw,noatime
/sys sysfs sysfs rw,nosuid,nodev,noexec
/proc/bus/usb usbfs usbfs rw
/proc proc proc rw,nosuid,nodev,noexec
/opt /dev/raid1/opt reiserfs rw,noatime
/mnt/sata /dev/sda6 ntfs ro,uid=1000,gid=0,fmask=0177,dmask=077,nls=utf8,errors=continue,mft_zone_multiplier=1
/mnt/checkouts /dev/raid0/co reiserfs rw,noatime
/lib/rcscripts/init.d none tmpfs rw,nosuid,nodev,noexec
/home/betelgeuse/scifi2 /dev/raid1/scifi2 reiserfs rw,nosuid,nodev,noexec,noatime
/home/betelgeuse/scifi /dev/raid1/scifi ext3 rw,nosuid,nodev,noexec,noatime,data=ordered
/home/betelgeuse/images /dev/maxtor/images reiserfs rw,nosuid,nodev,noexec,noatime
/home/betelgeuse/btdown /dev/raid0/btdown reiserfs rw,nosuid,nodev,noatime
/home /dev/raid1/home reiserfs rw,noatime
/dev/shm none tmpfs rw
/dev/pts devpts devpts rw,nosuid,noexec
/dev udev ramfs rw,nosuid
/ /dev/root reiserfs rw,noatime
Comment 1 Petteri Räty (RETIRED) gentoo-dev 2006-12-16 15:25:18 UTC
Created attachment 104176 [details, diff]
Patch for baselayout trunk to fix it
Comment 2 Petteri Räty (RETIRED) gentoo-dev 2006-12-16 15:26:23 UTC
Created attachment 104177 [details, diff]
Last one was borked.
Comment 3 Roy Marples (RETIRED) gentoo-dev 2006-12-17 14:24:51 UTC
This looks like a bug with GNU sort.
On FreeBSD we use sort from GNU coretutils 5.3 where sort -ur gives us the correct output.
Comment 4 Petteri Räty (RETIRED) gentoo-dev 2006-12-17 15:14:13 UTC
(In reply to comment #3)
> This looks like a bug with GNU sort.
> On FreeBSD we use sort from GNU coretutils 5.3 where sort -ur gives us the
> correct output.
> 

coreutils-6.7 here
Comment 5 SpanKY gentoo-dev 2006-12-18 23:40:02 UTC
i can only guess at Petteri's configuration since he neglected to post `emerge info` :P

on my amd64 stable system, coreutils-6.7 sorts properly ... but on my amd64 unstable system, coreutils-6.7 does not sort properly ... me thinks the significant difference lies in glibc (stable = glibc-2.4, unstable = glibc-2.5)
Comment 6 SpanKY gentoo-dev 2006-12-19 00:36:28 UTC
ok, i checked upstream ... baselayout needs to force LC_ALL=C when doing a sort of the mount points
Comment 7 Roy Marples (RETIRED) gentoo-dev 2006-12-19 02:37:46 UTC
get_mounts | LC_ALL=C sort -ur

Verified that works, patch is in SVN
Comment 8 Roy Marples (RETIRED) gentoo-dev 2006-12-19 09:28:28 UTC
Fixed in alpha10
Comment 9 Petteri Räty (RETIRED) gentoo-dev 2006-12-20 10:17:28 UTC
(In reply to comment #5)
> i can only guess at Petteri's configuration since he neglected to post `emerge
> info` :P
> 

In case you still care:
Portage 2.1.2_rc3-r6 (default-linux/x86/2006.1/desktop, gcc-4.1.1, glibc-2.5-r0, 2.6.19-gentoo-r2 i686)
=================================================================
System uname: 2.6.19-gentoo-r2 i686 Intel(R) Core(TM)2 CPU          6600  @ 2.40GHz
Gentoo Base System version 1.13.0_alpha9
Last Sync: Unknown
distcc 2.18.3 i686-pc-linux-gnu (protocols 1 and 2) (default port 3632) [disabled]
ccache version 2.4 [enabled]
dev-java/java-config: 1.3.7, 2.0.31
dev-lang/python:     2.4.4, 2.5-r1
dev-python/pycrypto: 2.0.1-r5
dev-util/ccache:     2.4-r6
sys-apps/sandbox:    1.2.18.1
sys-devel/autoconf:  2.13, 2.61
sys-devel/automake:  1.4_p6, 1.5, 1.6.3, 1.7.9-r1, 1.8.5-r3, 1.9.6-r2, 1.10
sys-devel/binutils:  2.17
sys-devel/gcc-config: 1.3.14
sys-devel/libtool:   1.5.22
virtual/os-headers:  2.6.17-r2
ACCEPT_KEYWORDS="x86 ~x86"
AUTOCLEAN="yes"
CBUILD="i686-pc-linux-gnu"
CFLAGS="-O2 -march=nocona -pipe"
CHOST="i686-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/kde/3.5/env /usr/kde/3.5/share/config /usr/kde/3.5/shutdown /usr/share/X11/xkb /usr/share/config"
CONFIG_PROTECT_MASK="/etc/env.d /etc/env.d/java/ /etc/gconf /etc/java-config/vms/ /etc/revdep-rebuild /etc/splash /etc/terminfo"
CXXFLAGS="-O2 -march=nocona -pipe"
DISTDIR="/var/distfiles"
FEATURES="autoaddcvs autoconfig ccache collision-protect cvs distlocks fixpackages java-strict parallel-fetch sandbox sfperms sign strict stricter userpriv usersandbox verify-rdepend"
GENTOO_MIRRORS=" http://trumpetti.atm.tut.fi/gentoo  http://lame.lut.fi/linux/gentoo "
LANG="en_US.utf8"
LC_ALL="en_US.utf8"
LDFLAGS="-Wl,--as-needed"
LINGUAS="fi"
MAKEOPTS="-j2"
PKGDIR="/home/pkg/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --delete-after --stats --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/mnt/checkouts/overlays/migrated-java /mnt/checkouts/overlays/betelgeuse"
SYNC="rsync://192.168.150.1:/portage"
USE="x86 aac acl acpi alsa alsa_cards_cs46xx alsa_cards_hda-intel arts audiofile bash-completion berkdb bitmap-fonts bluetooth bzip2 cairo cdb cddb cdparanoia cdr cli cracklib crypt cups dbus dlloader dri dts dvd dvdr dvdread elibc_glibc emboss esd fam ffmpeg firefox gif gstreamer hal iconv input_devices_evdev input_devices_keyboard input_devices_mouse isdnlog java jpeg kde kdeenablefinal kdehiddenvisibility kernel_linux libg++ linguas_fi logitech-mouse mad mikmod mjpeg mmx mp3 mpeg ncurses network nptl nptlonly nsplugin nvidia offensive ogg opengl pam pcre png ppds pppd qt3 quicktime readline real reflection rtc samba session spell spl sse sse2 ssl subversion svg symlink theora threads truetype truetype-fonts type1-fonts udev unicode usb userland_GNU userlocales video_cards_none video_cards_nvidia vim-syntax vorbis xcb xcomposite xinerama xml xorg xv xvid xvmc zlib"
Unset:  CTARGET, EMERGE_DEFAULT_OPTS, INSTALL_MASK, PORTAGE_RSYNC_EXTRA_OPTS