Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 158094 - java-pkg_get-target() in java-utils-2.eclass does not honour JAVA_PKG_WANT_TARGET properly
Summary: java-pkg_get-target() in java-utils-2.eclass does not honour JAVA_PKG_WANT_TA...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Eclasses (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Java team
URL:
Whiteboard:
Keywords:
: 159594 (view as bug list)
Depends on:
Blocks:
 
Reported: 2006-12-13 18:31 UTC by Vlastimil Babka (Caster) (RETIRED)
Modified: 2006-12-31 12:12 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
fix for the eclass (java-utils-2.eclass.target.patch,1.46 KB, patch)
2006-12-30 12:27 UTC, Vlastimil Babka (Caster) (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Vlastimil Babka (Caster) (RETIRED) gentoo-dev 2006-12-13 18:31:25 UTC
There are some "sanity checks" like "don't allow -target lower than the JDK version(s) specified in DEPEND + RDEPEND" and "don't allow -target higher than the JDK we're building with".

The first test is nonsense. There are cases when you need a 1.5 JDK because there are some API dependencies, but still want to retain 1.4 bytecode so you don't have to use 1.5 JDK (sometimes you even can't) with all stuff that depends on it. JAVA_PKG_WANT_TARGET is the way to specify this (see sun-javamail) but this sanity check prevents this. (sun-javamail is fine because it has target hardcoded in upstream build.xml and there's no rewriting but see its package.env and you'll see TARGET=1.5).

The second test makes some sense, but remember this is an override-variable so it should honour it no matter what (and then fail on building but then it's your fault you set it :)

java-pkg_get-source() doesn't make any tests like this, it honours JAVA_PKG_WANT_SOURCE unconditionally, and I think get-target() should do the same.
Comment 1 Vlastimil Babka (Caster) (RETIRED) gentoo-dev 2006-12-30 12:27:13 UTC
Created attachment 105007 [details, diff]
fix for the eclass

removes the "sanity checks"
Comment 2 Vlastimil Babka (Caster) (RETIRED) gentoo-dev 2006-12-30 17:48:17 UTC
Commited because stuff was already breaking because of this (tomcat) and patch helped.
Comment 3 William L. Thomson Jr. (RETIRED) gentoo-dev 2006-12-31 12:12:20 UTC
*** Bug 159594 has been marked as a duplicate of this bug. ***