Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 158030 - libgtop-2.14.6 fails to install on FreeBSD
Summary: libgtop-2.14.6 fails to install on FreeBSD
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] GNOME (show other bugs)
Hardware: All FreeBSD
: High normal (vote)
Assignee: Gentoo Linux Gnome Desktop Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-12-13 06:57 UTC by Roy Marples (RETIRED)
Modified: 2007-02-06 10:26 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
trivial patch (libgtop-2.14.4.patch,1.92 KB, patch)
2006-12-13 06:58 UTC, Roy Marples (RETIRED)
Details | Diff
FreeBSD only patch (libgtop-2.14.4-fbsd.patch,15.17 KB, patch)
2006-12-13 06:59 UTC, Roy Marples (RETIRED)
Details | Diff
FreeBSD patch (libgtop-2.14.4-fbsd.patch,14.73 KB, patch)
2006-12-18 08:39 UTC, Roy Marples (RETIRED)
Details | Diff
trivial patch (libgtop-2.14.4.patch,1.42 KB, patch)
2006-12-18 08:54 UTC, Roy Marples (RETIRED)
Details | Diff
FreeBSD patch (libgtop-2.14.6-fbsd.patch,14.60 KB, patch)
2007-01-18 13:56 UTC, Roy Marples (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Roy Marples (RETIRED) gentoo-dev 2006-12-13 06:57:25 UTC
And it requires a trivial patch that would be affected by Linux systems and a faily major patch that can only be applid to FreeBSD systems as it adds FreeBSD libs to the Makefile. As such, two patches will follow - they are based on the patches in FreeBSD ports (and one from steev) and they enable system-monitor to run correctly.
Comment 1 Roy Marples (RETIRED) gentoo-dev 2006-12-13 06:58:19 UTC
Created attachment 103948 [details, diff]
trivial patch
Comment 2 Roy Marples (RETIRED) gentoo-dev 2006-12-13 06:59:07 UTC
Created attachment 103949 [details, diff]
FreeBSD only patch

Should only be applied with use kernel_FreeBSD
Comment 3 Roy Marples (RETIRED) gentoo-dev 2006-12-18 08:39:07 UTC
Created attachment 104287 [details, diff]
FreeBSD patch

New patch should work fine with other OS's too
Comment 4 Roy Marples (RETIRED) gentoo-dev 2006-12-18 08:54:39 UTC
Created attachment 104289 [details, diff]
trivial patch

Same as before, just with the configure patch removed as it's been included in the new FreeBSD patch above
Comment 5 Roy Marples (RETIRED) gentoo-dev 2006-12-18 08:55:20 UTC
upstream bug
http://bugzilla.gnome.org/show_bug.cgi?id=387200
Comment 6 Roy Marples (RETIRED) gentoo-dev 2007-01-18 13:56:55 UTC
Created attachment 107376 [details, diff]
FreeBSD patch

Patch for 2.14.6
Comment 7 Daniel Gryniewicz (RETIRED) gentoo-dev 2007-01-26 02:24:53 UTC
The upstream bug has a comment, that I happen to agree with.  It really appears that result is declared, then checked without being set...
Comment 8 Roy Marples (RETIRED) gentoo-dev 2007-02-05 23:10:33 UTC
Upstream have merged my patch here.
http://bugzilla.gnome.org/attachment.cgi?id=81514&action=view

Can we get this in portage pretty please :)
Comment 9 Daniel Gryniewicz (RETIRED) gentoo-dev 2007-02-06 02:07:46 UTC
Done.

Can you test it to make sure I got my use check correct?  I'd prefer to not have to run eautoreconf everywhere, since it adds ~1/4 again to the merge time...

I did test the the patch and eautoreconf works correctly with the if statement commented out.
Comment 10 Roy Marples (RETIRED) gentoo-dev 2007-02-06 10:26:41 UTC
(In reply to comment #9)
> Done.
> 
> Can you test it to make sure I got my use check correct?  I'd prefer to not
> have to run eautoreconf everywhere, since it adds ~1/4 again to the merge
> time...

WFM

Blessed with the ~x86-fbsd keyword :)