Initial ebuild for Adblock Plus 0.7.2.2 an excellent plugin for Firefox. NOTE: I added i took the liberty of adding it to x11-plugins like the the x11-plugins/noscript ebuild, as this ebuild is almost exactly the same (and they're both firefox plugins it makes sense to put it in the same category as the other firefox plugin.
Created attachment 103605 [details] x11-plugins/adblock_plus-0.7.2.2.ebuild
Created attachment 103841 [details] x11-plugins/adblock_plus-0.7.2.3.ebuild
it would be nice if this ebuild could be made to support the other browsers that adblock works in, like seamonkey, mozilla, etc. possibly use USE flags to select which browsers it installs for? Tejing
Created attachment 104661 [details] 0.7.2.3 expanded to install for seamonkey and/or firefox based on USE vars this version installs for seamonkey as well. it takes a "seamonkey" and "firefox" as USE variables and installs for either or both.
Created attachment 104662 [details] 0.7.2.3 expanded to install for seamonkey and/or firefox based on USE vars this version installs for seamonkey as well. it takes a "seamonkey" and "firefox" as USE variables and installs for either or both.
bah... double post. sorry about that
Created attachment 104663 [details] x11-plugins/adblock_plus-0.7.2.3-r1.ebuild sigh... more spam for you guys >.< I missed I typo in the file I (double) uploaded before which kept it from working for firefox. here's a correct version.
This I do not see a reason for it in the tree. What is in the tree is just to help patch up security issues of major concern that keep poping up.
(In reply to comment #8) > This I do not see a reason for it in the tree. What is in the tree is just to > help patch up security issues of major concern that keep poping up. > I don't follow you. this is a convenience, clearly, but portage is really the only "right" way to use this software on a gentoo system, since this extension can't be installed on a profile, only in the main mozilla directory. also, according to addons.mozilla.org, it's one of the most used firefox/seamonkey extensions, so I think it's quite worthy of being included in portage.
Another reason is to force all users system-wide to use the plugin and not be able to un-install it without having root access.
yes, I can see many situations under which an admin might want to install this plugin system-wide with a basic set of filters to cut down on unneeded bandwidth use.
As Anarchy said, the only reason extensions are in the tree are for security issues. We can't add this ebuild to the tree, sorry.
oh I see. it's a matter of policy then? (seems an odd policy to me, but I'm sure there's a good reason) at any rate, I suppose the next step should be to submit this to the sunrise overlay? Tejing
(In reply to comment #13) > oh I see. it's a matter of policy then? (seems an odd policy to me, but I'm > sure there's a good reason) at any rate, I suppose the next step should be to > submit this to the sunrise overlay? > > Tejing > I personally would not as the ebuild incorrectly use parts of an eclass from the tree. It is very dirty and not something I would like to see other users using on a regular basis as a hack to get around the limitations of the eclass. Yes the eclass does need to be updated but there are better ways of doing this then adding a hack to an ebuild.
given that it appears that this software will never go into portage, and sunrise doesn't and shouldn't change eclasses, what other choice is there? I actually wrote a backwards-compatible change to the eclass and an ebuild to use it, but I've since deleted it since it appears it will never be useful... I guess what I'm saying is I agree with you, it's a dirty way to go about all of it, but stating that doesn't get anywhere. I'd be glad for a suggestion as to where to go with the general idea of making this software cleanly installable on gentoo, since currently the ONLY way to install this for seamonkey is to write your own ebuild or bypass portage entirely, neither of which I think the average user should need to do to use it.
Created attachment 105429 [details] x11-plugins/adblock_plus-0.7.2.3.ebuild Cleaned up the code a bit, and I'm going to put this up for review by the sunrise people. (also took the ebuild revision number off for sunrise)
(In reply to comment #16) > Created an attachment (id=105429) [edit] > x11-plugins/adblock_plus-0.7.2.3.ebuild > > Cleaned up the code a bit, and I'm going to put this up for review by the > sunrise people. (also took the ebuild revision number off for sunrise) > Please do not waste time. I am working on the eclass again and changes will come soon. At the same time I will have adblock added to the tree, Only reason for not adding this minute is the whole ebuild is a mess with you rewritting an eclass into the ebuild.
ah, I misunderstood. apologies.
Created attachment 108110 [details] adblock_plus-0.7.2.4.ebuild
