Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 157434 - xfce-extra/xfmedia (revised)
Summary: xfce-extra/xfmedia (revised)
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal
Assignee: XFCE Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-12-07 07:55 UTC by Sideris Michael
Modified: 2006-12-10 18:14 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
xfce-extra/xfmedia (revised) (xfmedia-0.9.2.ebuild,836 bytes, text/plain)
2006-12-07 07:58 UTC, Sideris Michael
Details
xfce-extra/xfmedia-0.9.2.ebuild (fixed the dbus deps) (xfmedia-0.9.2.ebuild,901 bytes, text/plain)
2006-12-07 08:40 UTC, Sideris Michael
Details
xfce-extra/xfmedia-0.9.2-r1.ebuild (xfmedia-0.9.2-r1.ebuild,881 bytes, text/plain)
2006-12-07 10:49 UTC, Sideris Michael
Details
xfce-extra/xfmedia-0.9.2-r1.ebuild (xfmedia-0.9.2-r1.ebuild,890 bytes, text/plain)
2006-12-07 12:09 UTC, Sideris Michael
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Sideris Michael 2006-12-07 07:55:41 UTC
A revised ebuild for xfce-extra/xfmedia. Adds 3 USE flags as well, dbus, debug and startup-notification. Much more compact, stripped the unnecassary stuff.
Comment 1 Sideris Michael 2006-12-07 07:58:24 UTC
Created attachment 103545 [details]
xfce-extra/xfmedia (revised)
Comment 2 Jakub Moc (RETIRED) gentoo-dev 2006-12-07 08:01:30 UTC
Comment on attachment 103545 [details]
xfce-extra/xfmedia (revised)

The dbus dependency is broken, please revert the change.
Comment 3 Sideris Michael 2006-12-07 08:40:01 UTC
Created attachment 103547 [details]
xfce-extra/xfmedia-0.9.2.ebuild (fixed the dbus deps)
Comment 4 Josh Nichols (RETIRED) gentoo-dev 2006-12-07 10:35:37 UTC
One problem: it wouldn't actually build anything :) you defined src_compile with econf, but make doesn't invoke.

There are ways to use the eclass in such a way that you don't have to redfine src_compile:

define XFCE_CONFIG to be "$(use_enable debug) $(use_enable startup-notification) $(use_enable dbus)"

xfce44_src_compile calls 'econf ${XFCE_CONFIG}', so defining XFCE_CONFIG in the ebuild will ensure that they get passed to configure.
Comment 5 Sideris Michael 2006-12-07 10:49:42 UTC
Created attachment 103561 [details]
xfce-extra/xfmedia-0.9.2-r1.ebuild

I guess this makes it final. Using the XFCE_CONFIG this time.
Comment 6 Josh Nichols (RETIRED) gentoo-dev 2006-12-07 11:01:47 UTC
Sorry... one last thing, probably want to set RDEPEND=${DEPEND}, as you'd likely need things like gtk at runtime :)
Comment 7 Sideris Michael 2006-12-07 12:09:53 UTC
Created attachment 103566 [details]
xfce-extra/xfmedia-0.9.2-r1.ebuild

Done.
Comment 8 Josh Nichols (RETIRED) gentoo-dev 2006-12-10 18:14:50 UTC
Suggestions applied, thanks for reprorting.

Just one thing to note, if you have USE based deps, there needs to be a space after the openning ( and before the closing ), ie "foo? ( xfce-base/xfce4-foo )"