Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 156557 - >=app-office/openoffice-bin/2.0.4 - invalid usage of RESTRICT=binchecks
Summary: >=app-office/openoffice-bin/2.0.4 - invalid usage of RESTRICT=binchecks
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High major (vote)
Assignee: Gentoo Office Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: binchecks
  Show dependency tree
 
Reported: 2006-11-28 14:54 UTC by Jakub Moc (RETIRED)
Modified: 2022-03-16 01:41 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jakub Moc (RETIRED) gentoo-dev 2006-11-28 14:54:55 UTC
This feature is NOT meant for hiding those scanelf QA warnings; that's what QA_{TEXTRELS,EXECSTACK,WX_LOAD} is for when the package can't be fixed. 

RESTRICT="binchecks" should _only_ be used for stuff where these checks don't make any sense and just cause needless overhead (pure data stuff, like kernel sources, icon packs, themes, fonts etc.)
Comment 1 solar (RETIRED) gentoo-dev 2006-12-03 17:49:06 UTC
QA: Removed invalid use of RESTRICT=binchecks
Comment 2 Andreas Proschofsky (RETIRED) gentoo-dev 2006-12-04 03:24:04 UTC
Why do you just remove the RESTRICT-statement without a proper fix? (actually breaking the ebuild for everyone who uses FEATURES="stricter" if I remember right)

For openoffice-bin we use the upstream binary, the checks report a few hundred hits, should I now add all these to the ebuild?
Comment 3 Jakub Moc (RETIRED) gentoo-dev 2006-12-04 03:43:28 UTC
Errr, it's not any more or less broken than it was with the bad restrict. (And, mind you that FEATURES=stricter is not intended for users in general, it's a developer feature). 

Anyway, RESTRICT=binchecks is NOT aimed at hiding this stuff, it's a feature to disable redundant checks for stuff where it doesn't make sense. zmedico already clarifies ebuild(5) manpages in this respect. What you probably intended was RESTRICT="stricter", then move to Bug 131633.

RESTRICT=binchecks should not be used for stuff that installs ELF binaries, end of story.
Comment 4 Jakub Moc (RETIRED) gentoo-dev 2006-12-04 03:58:44 UTC
To quote ebuild(5) in sys-apps/portage-2.1.2_rc2-r5:

binchecks
Disable  all  QA checks for binaries.  This should ONLY be used in packages for which binary checks make no sense (linux-headers and kernel-sources, for example, can safely be skipped since they have  no  binaries).
If the  binary checks need to be skipped for other reasons (such as proprietary binaries), see the QA CONTROL VARIABLES section for more specific exemptions.

If you think that RESTRICT="stricter" should exist, then there's Bug 131633. Closing this again.