Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 156079 - Stabilize x11-terms/aterm-1.0.1 (Was: x11-terms/aterm-1.0.0-r1 spewing geometry config messages.)
Summary: Stabilize x11-terms/aterm-1.0.1 (Was: x11-terms/aterm-1.0.0-r1 spewing geomet...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it
URL:
Whiteboard:
Keywords: STABLEREQ
Depends on:
Blocks:
 
Reported: 2006-11-23 20:03 UTC by Grant Edwards
Modified: 2008-02-20 19:31 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch removing the described output (patch.txt,758 bytes, patch)
2007-07-19 12:12 UTC, Andrew Hurst
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Grant Edwards 2006-11-23 20:03:19 UTC
x11-terms/aterm 1.0.0-r1

Spews a constant stream of messages anytime the window is moved or re-sized:

grante@ThinkGrant ~ $ aterm
config_geom = 741x364
root_geom = 741x364+653+674, root_size = 1400x1050
config_geom = 750x364
root_geom = 750x364+644+674, root_size = 1400x1050
config_geom = 750x379
root_geom = 750x379+644+659, root_size = 1400x1050
config_geom = 759x379
root_geom = 759x379+635+659, root_size = 1400x1050
config_geom = 759x394
root_geom = 759x394+635+644, root_size = 1400x1050
config_geom = 768x409
root_geom = 768x409+626+629, root_size = 1400x1050
config_geom = 777x424
root_geom = 777x424+617+614, root_size = 1400x1050
config_geom = 786x439
root_geom = 786x439+608+599, root_size = 1400x1050
config_geom = 795x454
root_geom = 795x454+599+584, root_size = 1400x1050
Comment 1 wic 2006-11-29 09:36:01 UTC
Also, aterm seems to recalculate the background image when it is redrawing itself. 

For instance, when switching between two virtual desktops and having aterm on one of them. Or simply when resizing.

The result is a noticeable flash/blink which is very annoying. I had to revert to x11-terms/aterm-0.4.2-r11.
Comment 2 Walther 2006-12-14 19:38:52 UTC
Aterm 1.0.0 was released on July 5, 2005, and only now people are complaining of this? why noone noticed it in over a year? Is not like noone ever opens an aterm from within another aterm. The spammage is highly annoying. And it was kinda sloppy to leave those messages there....

Looks like someone was debugging the resize code, and forgot to remove the debug messages....
I know I provide no useful additional info, but this is such a simple bug to fix, and it's SO ANNOYING, I really wish it were fixed pronto (and not force me to create an overlay ebuild with a 'patch' to remove those two lines).

src/main.c:
/*
 * Redraw window after exposure or size change
 */
/* PROTO */
void
resize_window(XEvent* ev)
{
   int root_x = 0, root_y = 0;
   Window        wdumm;
   XConfigureEvent *xconf = &(ev->xconfigure);
   
   while( XCheckTypedWindowEvent( Xdisplay, TermWin.parent, ConfigureNotify, ev ) );
   fprintf( stderr, "config_geom = %dx%d\n", xconf->width, xconf->height );
    resize_window1(xconf->width, xconf->height);
#if 1
   XTranslateCoordinates (Xdisplay, TermWin.parent, Xroot, 0, 0, &root_x, &root_y, &wdumm);
   
   fprintf( stderr, "root_geom = %dx%d%+d%+d, root_size = %dx%d\n", xconf->width, xconf->height, root_x, root_y, XdisplayWidth, XdisplayHeight );
   TermWin.root_x = root_x ; 
   TermWin.root_y = root_y ;
   TermWin.root_width = xconf->width ;
   TermWin.root_height = xconf->height ;
Comment 3 Grant Edwards 2007-05-14 16:42:21 UTC
Is there anything we can do to get this bug fixed?  Should I submit a patch that comments out those two fprintf() calls?
Comment 4 Walther 2007-05-14 17:38:54 UTC
This 'bug' really belongs to upstream, but I have no idea how to contact them (I've tried and failed to find any bugzillas or the like for the aterm component of the AfterStep project). The lack of reply from the Gentoo Developers in charge would indicate either lack of care, or lack of replies from upstream as to reply with anything meaningful here.

The proper fix is to have upstream release a new version, but I think that's unlikely in the near future. There could be a new revision bump with the patch to fix it, but that would be the 'improper' way to correct the bug. I got fed of it long ago, and now I am using an overlayed aterm-1.0.0-r2 ebuild to make those messages go away.
Comment 5 Grant Edwards 2007-05-14 17:45:25 UTC
I guess I'll add it to my overlay as well.
Comment 6 Andrew Hurst 2007-07-19 12:12:57 UTC
Created attachment 125327 [details, diff]
Patch removing the described output

There doesn't seem to be a DEBUG #define for this sort of output, so I'm going for  the 'remove' option
Comment 7 Andrew Hurst 2007-08-01 12:55:27 UTC
Who is currently looking after aterm?
I reckon I could manage adding the patches in 156079 and 139554 to the ebuild to make 1.0.0-r2
Comment 8 Nathan Mahon 2007-08-01 17:17:38 UTC
both are fixed in upstream cvs. what we need is a release. :)
Comment 9 Nathan Mahon 2007-08-01 20:49:46 UTC
could someone verify this is fixed in 1.0.1 and close this bug?
Comment 10 Andrew Hurst 2007-08-02 00:02:17 UTC
I confirm the geometry config messages are gone in 1.0.1.
This bug is fixed.

Thanks again Vae.
Comment 11 Andrew Hurst 2007-08-09 21:58:08 UTC
this bug can be closed. [is resolved fixed]
Comment 12 Santiago M. Mola (RETIRED) gentoo-dev 2008-02-14 21:03:51 UTC
CC'ing arches, stabilize 1.0.1
Comment 13 Markus Meier gentoo-dev 2008-02-14 21:56:42 UTC
x86 stable, please note:
dodoc: doc/BUGS does not exist
 * QA Notice: Pre-stripped files found:
 * /var/tmp/portage/x11-terms/aterm-1.0.1/image/usr/bin/aterm
Comment 14 nixnut (RETIRED) gentoo-dev 2008-02-15 18:25:58 UTC
ppc stable
Comment 15 Raúl Porcel (RETIRED) gentoo-dev 2008-02-20 19:31:25 UTC
sparc stable, closing