Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 155177 - media-sound/ncmpc-0.11.1: patch to fix UTF8 issues
Summary: media-sound/ncmpc-0.11.1: patch to fix UTF8 issues
Status: RESOLVED TEST-REQUEST
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High minor (vote)
Assignee: Andrej Kacian (RETIRED)
URL: http://www.musicpd.org/mantis/view.ph...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-11-14 16:10 UTC by Sebastian
Modified: 2007-04-04 07:47 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
ncmpc-utf.patch (ncmpc-utf.patch,6.08 KB, patch)
2006-11-14 16:12 UTC, Sebastian
Details | Diff
ncmpc-0.11.1.ebuild (ncmpc-0.11.1-r1.ebuild,1.07 KB, text/plain)
2006-11-14 16:13 UTC, Sebastian
Details
ncmpc-utf.patch (ncmpc-utf.patch,6.47 KB, patch)
2006-12-27 21:52 UTC, gtlinuxman
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sebastian 2006-11-14 16:10:56 UTC
Patch from http://www.musicpd.org/mantis/view.php?id=476
Comment 1 Sebastian 2006-11-14 16:12:01 UTC
Created attachment 101956 [details, diff]
ncmpc-utf.patch

Details at http://www.musicpd.org/mantis/view.php?id=476
Comment 2 Sebastian 2006-11-14 16:13:47 UTC
Created attachment 101957 [details]
ncmpc-0.11.1.ebuild

Updated ebuild, ncmpc works fine with the patch. Had issues with volume display, patch fixed that.
Comment 3 Sebastian 2006-11-14 16:25:10 UTC
Patch seems to need some work, it uses libcursesw unconditionally for one. :-)
Comment 4 Andrej Kacian (RETIRED) gentoo-dev 2006-11-15 10:07:28 UTC
Let's just wait for upstream's reaction here, shall we?
Comment 5 Sebastian 2006-11-15 12:19:36 UTC
Your call. I read that the ncmpc dev didn't surface for a long time (last ncmpc change according to svn was 2006-03-31) and that there's a ncmpc svn branch named tradiaz. I don't know wheter ncmpc will ever be maintained anymore at all or tradiaz will ever make a release.
Comment 6 Andrej Kacian (RETIRED) gentoo-dev 2006-11-16 04:44:03 UTC
When I last spoke to tradiaz on IRC, I think he mentioned wanting to make a release.

kaw (the original maintainer) appears from time to time, not very often.
Comment 7 Sebastian 2006-11-16 07:45:10 UTC
Thanks for the info. The client is way to nice to not get any attention.
Comment 8 gtlinuxman 2006-12-27 21:52:19 UTC
Created attachment 104831 [details, diff]
ncmpc-utf.patch
Comment 9 gtlinuxman 2007-03-23 05:20:13 UTC
Comment on attachment 104831 [details, diff]
ncmpc-utf.patch

+russian charset fix
Comment 10 Andrej Kacian (RETIRED) gentoo-dev 2007-03-28 21:52:39 UTC
Ok, no point in waiting for upstream this long. I've applied the patch in 0.11.1-r2, please give it a try. I suspect the Russian message catalog doesn't get rebuilt after the patch.
Comment 11 Mathias Gumz 2007-04-04 07:17:21 UTC
doesnt work for me because i dont want my ncurses lib to be compiled with unicode.. hence i dont have libncursesw on my system ... which leads to link error:

gcc  -mtune=i686 -O2 -pipe  -Wl,-z,now,-O1 -o ncmpc libmpdclient.o main.o mpdclient.o options.o conf.o command.o screen.o screen_utils.o screen_play.o screen_file.o screen_search.o screen_help.o screen_keydef.o screen_clock.o list_window.o colors.o support.o wreadln.o strfsong.o utils.o  -lglib-2.0   -lncursesw
/usr/lib/gcc/i686-pc-linux-gnu/4.1.2/../../../../i686-pc-linux-gnu/bin/ld: cannot find -lncursesw
collect2: ld returned 1 exit status
make[2]: *** [ncmpc] Error 1
make[2]: Leaving directory `/var/tmp/paludis/media-sound/ncmpc-0.11.1-r2/work/ncmpc-0.11.1/src'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/var/tmp/paludis/media-sound/ncmpc-0.11.1-r2/work/ncmpc-0.11.1'
make: *** [all] Error 2

!!! ERROR in media-sound/ncmpc-0.11.1-r2:
!!! In src_compile at line 3473
!!! make failed

!!! Call stack:
!!!    * src_compile (/var/tmp/paludis/media-sound/ncmpc-0.11.1-r2/temp/loadsaveenv:3473)
!!!    * ebuild_f_compile (/usr/libexec/paludis/src_compile.bash:51)
!!!    * ebuild_main (/usr/libexec/paludis/ebuild.bash:354)
!!!    * main (/usr/libexec/paludis/ebuild.bash:372)

Comment 12 Andrej Kacian (RETIRED) gentoo-dev 2007-04-04 07:47:03 UTC
(In reply to comment #11)
> doesnt work for me because i dont want my ncurses lib to be compiled with
> unicode.. hence i dont have libncursesw on my system ... 

Right, I completely forgotten that libncursesw is optional. I've changed the ebuild to only be applied if ncurses has been built with unicode USE flag.

Thanks.