Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 155160 - silence warnings when compiling app-portage/eix-0.8.1
Summary: silence warnings when compiling app-portage/eix-0.8.1
Status: RESOLVED UPSTREAM
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Martin Väth
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-11-14 12:33 UTC by hiyuh
Modified: 2006-11-19 08:21 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
a patch to silence some warnings for app-portage/eix-0.8.1 (eix-0.8.1-warnings.patch,6.49 KB, patch)
2006-11-14 12:41 UTC, hiyuh
Details | Diff
summary of this patch (summary_of_this_patch.txt,22.12 KB, text/plain)
2006-11-14 12:50 UTC, hiyuh
Details

Note You need to log in before you can comment on or make changes to this bug.
Description hiyuh 2006-11-14 12:33:22 UTC
app-portage/eix-0.8.1 works great.
But it seems have some wrong order of constructor initialize or so (try w/ -Wall).
I've poked it to fix, and I'll submit my patches.

However, I'm not C++ coder.
So, if maintainers or devs have a time to review'n'test and these are real fix,
please consider to merge.
Comment 1 hiyuh 2006-11-14 12:41:38 UTC
Created attachment 101943 [details, diff]
a patch to silence some warnings for app-portage/eix-0.8.1
Comment 2 hiyuh 2006-11-14 12:50:23 UTC
Created attachment 101946 [details]
summary of this patch

I'll post pre-patched/post-patched warning snippet of,
"ebuild eix-0.8.1.ebuild compile 1> /dev/null 2>/warnings"
These logs comes from w/ USE="sqlite" CXXFLAGS="-Os -Wall".
Comment 3 Martin Väth 2006-11-14 16:38:35 UTC
Thanks for your patches. Good work.

I merged them with eix' current svn trunk with the only exception that the two "int" -> "unsigned int" conversions were turned into conversions to string::size_type and vector<string>::size_type, respectively, which I guess is probably somewhat cleaner.

Since it appears that you created the patches manually in several steps (they needed different -p? numbers) some suggestion: If you patch an svn hosted project like eix, it is probably simpler for you (and the maintainer) if you call (in the eix example)
  svn co http://dev.croup.de/repos/eix/trunk
to create your local copy of the trunk directory (later on, "svn update" in this directory suffices), make your patches and testing in this directory and then simply call "svn diff" in this directory to create the patches.
Comment 4 hiyuh 2006-11-15 05:36:16 UTC
(In reply to comment #3)
> Thanks for your patches. Good work.

I'd have to say exactly same line, your quick response really rocks. :)

> I merged them with eix' current svn trunk with the only exception that the two
> "int" -> "unsigned int" conversions were turned into conversions to
> string::size_type and vector<string>::size_type, respectively, which I guess is
> probably somewhat cleaner.

ACK.

> Since it appears that you created the patches manually in several steps (they
> needed different -p? numbers) some suggestion: If you patch an svn hosted
> project like eix, it is probably simpler for you (and the maintainer) if you
> call (in the eix example)
>   svn co http://dev.croup.de/repos/eix/trunk
> to create your local copy of the trunk directory (later on, "svn update" in
> this directory suffices), make your patches and testing in this directory and
> then simply call "svn diff" in this directory to create the patches.

I'm really new to use of Subversion b/c only what I use was Mercurial.
Thanks for your suggestion, memorized.
Comment 5 Martin Väth 2006-11-19 08:21:10 UTC
Since eix-0.8.2 contains the patches and is now officially released, I mark this bug as "resolved upstream".